Skip to content

central_systest_blobs: generalize the GCS helpers to fetch and upload arbitrary objects - #14920

Merged
itamar-starkware merged 1 commit into
mainfrom
central-systest-blobs-generalize-gcs-helpers
Aug 5, 2026
Merged

central_systest_blobs: generalize the GCS helpers to fetch and upload arbitrary objects#14920
itamar-starkware merged 1 commit into
mainfrom
central-systest-blobs-generalize-gcs-helpers

Conversation

@itamar-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor in cende_blob_regression_test.rs with no production or runtime path changes.

Overview
Refactors the Cende blob regression test’s GCS utilities so downloads and uploads are keyed by an explicit object path instead of a blobs-only generation helper.

fetch_raw_blobs_at_generation is replaced by fetch_raw_object, which takes any GCS object name. upload_new_object centralizes create-only uploads (if_generation_match: 0) with caller-supplied object path and string body. bump_generation_and_store_blob_file and fetch_blob_file now compose those helpers with blobs_object_path and normalized JSON; generation discovery and local generation file updates are unchanged.

Reviewed by Cursor Bugbot for commit f6638b3. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@itamar-starkware
itamar-starkware marked this pull request as ready for review August 5, 2026 07:44

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@itamar-starkware
itamar-starkware changed the base branch from remove-os-input-feature to graphite-base/14920 August 5, 2026 12:51
@itamar-starkware
itamar-starkware force-pushed the central-systest-blobs-generalize-gcs-helpers branch from 235c563 to f6638b3 Compare August 5, 2026 12:51
@itamar-starkware
itamar-starkware changed the base branch from graphite-base/14920 to main August 5, 2026 12:51
@itamar-starkware
itamar-starkware added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit 15e5b74 Aug 5, 2026
16 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants