Skip to content

central_systest_blobs: carry real witness fields in the regression blobs - #14910

Draft
itamar-starkware wants to merge 1 commit into
remove-os-input-featurefrom
central-systest-blobs-carry-witness-fields
Draft

central_systest_blobs: carry real witness fields in the regression blobs#14910
itamar-starkware wants to merge 1 commit into
remove-os-input-featurefrom
central-systest-blobs-carry-witness-fields

Conversation

@itamar-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are confined to regression test/fixture generation in central_systest_blobs; production cende paths are unchanged aside from exercising the same commit/witness APIs already used elsewhere.

Overview
Updates the central systest blob regression factory so generated AerospikeBlob fixtures match what the batcher/OS expect: Patricia witnesses, trimmed initial reads, and recent state commitment infos with the same one-block lag as live cende recording.

Block closing now derives AccessedKeys, commits via commit_state_diff_with_witnesses on IndexDb (replacing FactsDb / commit_state_diff), trims initial_reads to accessed keys, and stores StateCommitmentInfos per block. In finalize, each blob gets the previous block’s compressed commitment infos (first blob gets none), mirroring recent_block_hashes behavior.

The GCS regression check compares blobs through to_comparable_blobs, decompressing state_commitment_infos so bincode-backed maps don’t flake across processes. GCS upload/download helpers are lightly refactored, and the pinned blob generation is bumped (55 → 58).

Reviewed by Cursor Bugbot for commit 4eb6f8f. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

itamar-starkware commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit da6f991. Configure here.

Comment thread crates/central_systest_blobs/src/cende_blob_regression_test.rs Outdated
@itamar-starkware
itamar-starkware force-pushed the central-systest-blobs-carry-witness-fields branch from da6f991 to c065071 Compare August 2, 2026 12:55
@itamar-starkware
itamar-starkware force-pushed the itamar/tests/rust-serde-fixtures-for-python branch from d8061e4 to 6b2e975 Compare August 2, 2026 12:55
@itamar-starkware
itamar-starkware force-pushed the central-systest-blobs-carry-witness-fields branch from c065071 to 4bb525f Compare August 2, 2026 17:25
@itamar-starkware
itamar-starkware force-pushed the itamar/tests/rust-serde-fixtures-for-python branch 2 times, most recently from ed63868 to 8d91fbf Compare August 2, 2026 20:22
@itamar-starkware
itamar-starkware force-pushed the central-systest-blobs-carry-witness-fields branch from 4bb525f to 5170ea2 Compare August 2, 2026 20:22
@itamar-starkware
itamar-starkware force-pushed the itamar/tests/rust-serde-fixtures-for-python branch from 8d91fbf to 3319911 Compare August 3, 2026 08:10
@itamar-starkware
itamar-starkware force-pushed the central-systest-blobs-carry-witness-fields branch from 5170ea2 to 681affd Compare August 3, 2026 08:10
@itamar-starkware
itamar-starkware changed the base branch from itamar/tests/rust-serde-fixtures-for-python to graphite-base/14910 August 3, 2026 11:36
@itamar-starkware
itamar-starkware force-pushed the central-systest-blobs-carry-witness-fields branch from 681affd to 4d4bb00 Compare August 3, 2026 11:36
@itamar-starkware
itamar-starkware changed the base branch from graphite-base/14910 to remove-os-input-feature August 3, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants