Skip to content

apollo_integration_tests: validate cende blob witness fields in the dummy recorder - #14904

Open
itamar-starkware wants to merge 1 commit into
witness-flow-assertionsfrom
dummy-recorder-validates-blob
Open

apollo_integration_tests: validate cende blob witness fields in the dummy recorder#14904
itamar-starkware wants to merge 1 commit into
witness-flow-assertionsfrom
dummy-recorder-validates-blob

Conversation

@itamar-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Aug 1, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are confined to integration-test harness code (dummy HTTP recorder), not production cende or consensus paths.

Overview
Integration tests no longer use a no-op cende recorder: the local dummy recorder now behaves more like production for witness shipping and validation.

Blob validation: Each write_blob request is parsed as JSON and must include recent_state_commitment_infos and initial_reads. Missing fields yield 400 Bad Request so the cende client’s retry path fails fast instead of treating bad blobs as success.

RecorderStats: A shared RecorderStats tracks blobs received, blobs with commitment infos, invalid blobs, and a commitment_infos_height_offset derived from stored witness block numbers. Flow setup exposes this as FlowSequencerSetup::recorder_stats for assertions.

Height offset endpoint: commitment_infos_height_offset starts as null (empty recorder) and advances after valid blobs with non-empty recent_state_commitment_infos, matching the production recorder contract for one-time witness delivery.

Large payloads: Axum’s default 2MB body limit is disabled on the recorder router so blobs with declared classes and execution info are accepted, as before validation was added.

Reviewed by Cursor Bugbot for commit 48efd34. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Comment thread crates/apollo_integration_tests/src/utils.rs

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 040098a. Configure here.

Comment thread crates/apollo_integration_tests/src/utils.rs
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from ae1112c to 74bab51 Compare August 2, 2026 12:55
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 040098a to 143de6b Compare August 2, 2026 12:55
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 74bab51 to 74c75f1 Compare August 2, 2026 17:25
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 143de6b to 3d19aeb Compare August 2, 2026 17:25
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 74c75f1 to c07734c Compare August 2, 2026 20:22
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 3d19aeb to 3409297 Compare August 2, 2026 20:22
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from c07734c to 74b2fe0 Compare August 3, 2026 08:10
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 3409297 to 32bce07 Compare August 3, 2026 08:10
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 74b2fe0 to ce56e32 Compare August 3, 2026 11:36
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 32bce07 to 14fc697 Compare August 3, 2026 11:36
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from ce56e32 to d164fa6 Compare August 3, 2026 13:48
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 14fc697 to bc37469 Compare August 3, 2026 13:48
@itamar-starkware
itamar-starkware marked this pull request as ready for review August 3, 2026 20:32
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from d164fa6 to e30f09c Compare August 3, 2026 20:49
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch 2 times, most recently from 47204b5 to 658dc79 Compare August 4, 2026 10:23
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 658dc79 to 8c42fd0 Compare August 4, 2026 14:59
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from e30f09c to 3752bf6 Compare August 4, 2026 14:59
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 8c42fd0 to 96a3bc9 Compare August 5, 2026 07:44
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 3752bf6 to 63dab7b Compare August 5, 2026 07:44
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 63dab7b to c439885 Compare August 5, 2026 12:51
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 96a3bc9 to b9b1ffa Compare August 5, 2026 12:51
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from c439885 to 49ca0c1 Compare August 5, 2026 13:56
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from b9b1ffa to 31f023e Compare August 5, 2026 13:56
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 49ca0c1 to 6f0de56 Compare August 6, 2026 06:19
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 31f023e to 005e60a Compare August 6, 2026 06:19
@itamar-starkware
itamar-starkware force-pushed the witness-flow-assertions branch from 6f0de56 to debeaf5 Compare August 6, 2026 09:55
@itamar-starkware
itamar-starkware force-pushed the dummy-recorder-validates-blob branch from 005e60a to 48efd34 Compare August 6, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants