Skip to content

workspace,ci: remove the os_input feature (make it unconditional) - #14902

Open
itamar-starkware wants to merge 1 commit into
mainfrom
remove-os-input-feature
Open

workspace,ci: remove the os_input feature (make it unconditional)#14902
itamar-starkware wants to merge 1 commit into
mainfrom
remove-os-input-feature

Conversation

@itamar-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Aug 1, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Always-on OS-input storage and committer witness paths widen the default production surface (Patricia witness fetch, extra DB tables/files) compared to builds that previously omitted os_input; behavior should match the old feature-enabled builds but any latent #[cfg(feature = "os_input")] leftovers would fail to compile or gate metrics incorrectly.

Overview
Makes OS replay input (accessed keys, Patricia witnesses via ReadPathsAndCommitBlock, initial_reads, compressed state commitment infos, Cende blob fields) always on by deleting the workspace-wide os_input feature and the optional dependency wiring behind it.

Build & CI: Drops os_input from crate Cargo.toml files (batcher, committer, storage, blockifier, integration tests, etc.), promotes former optional deps to normal deps where needed, and removes .github/workflows/apollo_storage_os_input_ci.yml (no more separate --features os_input test matrix).

Runtime behavior (unchanged logic, single path): Batcher always persists accessed keys, trims initial reads, and routes commitment tasks to ReadPathsAndCommitBlock when keys exist; storage always exposes accessed_keys / state_commitment_infos tables and mmap files (MAX_DBS 27). Committer always uses witness-aware forest writes and exposes read_paths_and_commit_block. Batcher types always include GetStateCommitmentInfos and CentralObjects::initial_reads.

Code cleanup: Removes duplicate trait methods, #[cfg(feature = "os_input")] branches, and feature-gated test helpers; consolidates committer ComponentRequestHandler to one impl with ForestStorageWithWitnesses.

Observability: Grafana dev dashboard adds panels for get_state_commitment_infos and read_paths_and_commit_block request metrics.

Reviewed by Cursor Bugbot for commit d52c949. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

itamar-starkware commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

@itamar-starkware
itamar-starkware force-pushed the remove-os-input-feature branch from 46567d7 to d52c949 Compare August 2, 2026 20:22

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d52c949. Configure here.

Ok(())
}

#[cfg(feature = "os_input")]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover os_input feature gates

Medium Severity

The os_input feature was removed from apollo_consensus_orchestrator, but #[cfg(feature = "os_input")] still guards the CENDE_LAST_STATE_COMMITMENT_INFOS_BLOCK_NUMBER import and the update after a successful blob write. That cfg never enables, so the metric stays unset even though witness data is now always produced.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d52c949. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants