blockifier,blockifier_reexecution: opt out of OS read collection when replaying recorded state - #14907
Conversation
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 947e9c0. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 2 comments.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on itamar-starkware).
crates/blockifier/src/blockifier/transaction_executor.rs line 247 at r1 (raw file):
block_state: &mut CachedState<S>, block_context: &BlockContext, collect_os_initial_reads: bool,
I'm looking for a way to enforce the collection of the initial reads in production by the compiler.
What about this?
pub enum OsReadsCollection {
Collect,
#[cfg(feature = "reexecution")]
Skip,
}
Code quote:
collect_os_initial_reads: bool,crates/central_systest_blobs/src/cende_blob_regression_test.rs line 339 at r1 (raw file):
.push(InternalTransactionWithReceipt { transaction: internal, execution_info }); } let summary = executor.non_consuming_finalize(true).unwrap();
Add TODO here, and please add it to Monday as well.
|
Previously, yoavGrs wrote…
If enum with one option is working I think it's a good approach. |
|
Previously, yoavGrs wrote…
TODO of what? |
… replaying recorded state
3d96f8b to
947e9c0
Compare
f21d89a to
46567d7
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on itamar-starkware).
a discussion (no related file):
Close this PR and review this: https://app.graphite.com/github/pr/starkware-libs/sequencer/14911

No description provided.