Repository navigation
Fix Console tab crash after a screen size change - #185
Merged
Merged
Conversation
console_scroll_view was a FrameLayout in the phone console layout and a ScrollView in the large layout. State saved under that id on a phone size was restored into the ScrollView after the screen became large (fold open, window resize), so opening the Console tab threw ClassCastException in ScrollView.onRestoreInstanceState. Drop the unused id from the phone FrameLayout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this crash from the Play Console (v2.59 to v2.61):
console_scroll_viewwas a FrameLayout inlayout/fragment_console_tab.xml(since dce94d7) but a ScrollView inlayout-large/fragment_console_tab.xml. State saved under that id on a phone size was restored into the ScrollView after the screen became large (fold open, window resize), when the Console tab was opened again.layout/andlayout-large/has this type mismatch.wm size,wm density), open Console. Crashed before the fix, opens now. The reverse (large to phone) also opens. The phone Console tab looks the same as before../gradlew buildpasses locally.