Skip to content

Fix Console tab crash after a screen size change #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeevy merged 1 commit into from
Oct 10, 2026
Merged

Fix Console tab crash after a screen size change #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/res/layout/fragment_console_tab.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@
<variable name="machineStatus" type="in.co.gorest.grblcontroller.listeners.MachineStatusListener" />
</data>

<!-- Not a ScrollView: the page must stay screen high so the console well takes the spare space. -->
<!-- Not a ScrollView: the page must stay screen high so the console well takes the spare space.
No id: the large layout uses console_scroll_view on a ScrollView, and the same id on a
different view type crashes the view state restore when the screen size changes. -->
<FrameLayout
android:paddingStart="@dimen/screen_edge"
android:paddingEnd="@dimen/screen_edge"
android:id="@+id/console_scroll_view"
android:paddingTop="@dimen/spacing_s"
android:layout_width="match_parent"
android:layout_height="match_parent">
Expand Down
Loading