apollo_dashboard: alert on committer block number lag - #14936
apollo_dashboard: alert on committer block number lag#14936itamar-starkware wants to merge 2 commits into
Conversation
PR SummaryLow Risk Overview Introduces a P2 alert Reviewed by Cursor Bugbot for commit cc98834. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
eead3b1 to
cc98834
Compare
29e359e to
835b2c6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc98834. Configure here.
| } | ||
|
|
||
| /// 9 fires at the STORED_BLOCK_HASH_BUFFER gate (10): integer gauges + strict `>`. | ||
| const COMMITTER_LAG_ALERT_THRESHOLD_BLOCKS: f64 = 9.0; |
There was a problem hiding this comment.
Off-by-one lag alert threshold
Medium Severity
COMMITTER_LAG_ALERT_THRESHOLD_BLOCKS is 9.0 with strict >, so the alert only fires at lag >= 10. The state-commitment gate uses (height + 1) - STORED_BLOCK_HASH_BUFFER, i.e. it already fails when lag reaches 9 (committer_offset <= height - 9). The comment assumes the gate is at 10, so paging starts one block after proposal building is already blocked.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit cc98834. Configure here.
There was a problem hiding this comment.
Is it true? Are we blocked on 9?
itamar-starkware
left a comment
itamar-starkware
left a comment
There was a problem hiding this comment.
@itamar-starkware made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on yoavGrs).
| } | ||
|
|
||
| /// 9 fires at the STORED_BLOCK_HASH_BUFFER gate (10): integer gauges + strict `>`. | ||
| const COMMITTER_LAG_ALERT_THRESHOLD_BLOCKS: f64 = 9.0; |
There was a problem hiding this comment.
Is it true? Are we blocked on 9?
itamar-starkware
left a comment
itamar-starkware
left a comment
There was a problem hiding this comment.
@itamar-starkware made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on yoavGrs).
| } | ||
|
|
||
| /// 9 fires at the STORED_BLOCK_HASH_BUFFER gate (10): integer gauges + strict `>`. | ||
| const COMMITTER_LAG_ALERT_THRESHOLD_BLOCKS: f64 = 9.0; |
2 participants
No description provided.