Skip to content

apollo_dashboard: panel for consensus vs cende state commitment infos gap - #14941

Merged
itamar-starkware merged 1 commit into
mainfrom
committer-consensus-cende-gap-panel
Aug 12, 2026
Merged

apollo_dashboard: panel for consensus vs cende state commitment infos gap#14941
itamar-starkware merged 1 commit into
mainfrom
committer-consensus-cende-gap-panel

Conversation

@itamar-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Aug 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Dashboard-only observability change; no runtime, consensus, or Cende write-path logic is modified.

Overview
Adds a Cende Grafana timeseries that shows how far the last sent state-commitment-infos blob trails consensus (max(consensus_block_number) - max(cende_last_state_commitment_infos_block_number)).

The query drops the pod label filter so metrics from different pods can be compared, and turns red at STORED_BLOCK_HASH_BUFFER—the point where the retrospective gate starts erroring.

Reviewed by Cursor Bugbot for commit 9f7628f. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@itamar-starkware
itamar-starkware marked this pull request as ready for review August 10, 2026 13:47
@itamar-starkware
itamar-starkware force-pushed the committer-consensus-cende-gap-panel branch from 6a7a56a to e0de47f Compare August 11, 2026 08:18

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on itamar-starkware).


a discussion (no related file):
Please add a threshold line at gap=10

@itamar-starkware
itamar-starkware changed the base branch from committer-witness-blob-size-log to main August 12, 2026 11:38
@itamar-starkware
itamar-starkware force-pushed the committer-consensus-cende-gap-panel branch from e0de47f to 9f7628f Compare August 12, 2026 13:08

@itamar-starkware itamar-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itamar-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on yoavGrs).


a discussion (no related file):

Previously, yoavGrs wrote…

Please add a threshold line at gap=10

Done

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).

@itamar-starkware
itamar-starkware added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit 16e916b Aug 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants