Skip to content

apollo_batcher: debug-log compressed byte size of committer-returned commitment infos - #14891

Open
itamar-starkware wants to merge 1 commit into
committer-latency-alertsfrom
committer-witness-blob-size-log
Open

apollo_batcher: debug-log compressed byte size of committer-returned commitment infos#14891
itamar-starkware wants to merge 1 commit into
committer-latency-alertsfrom
committer-witness-blob-size-log

Conversation

@itamar-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Debug-only logging behind existing tracing; no behavior or data-path changes.

Overview
Adds a debug! trace in the os_input ReadPathsAndCommitBlock path right after the committer responds, so operators can see how many bytes of compressed state commitment infos came back for each block height.

This is observability only: no change to commitment handling, retries, or what gets passed downstream.

Reviewed by Cursor Bugbot for commit 6a4d13c. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from 105f478 to 2d724bf Compare July 28, 2026 11:22
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from 85f6cc5 to 2a70bcc Compare July 28, 2026 11:22
@itamar-starkware
itamar-starkware marked this pull request as ready for review July 28, 2026 11:31
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from 2a70bcc to fe2372b Compare July 28, 2026 12:05
@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from 2d724bf to 01def9f Compare July 28, 2026 12:05
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from fe2372b to e598d8c Compare July 28, 2026 13:42
@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from 01def9f to 3ed55ca Compare July 28, 2026 13:42
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from e598d8c to 57d1f68 Compare July 28, 2026 14:21
@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from 3ed55ca to 795cf75 Compare July 28, 2026 14:21
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from 57d1f68 to cee73da Compare July 29, 2026 10:28
@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from 795cf75 to fa82ee8 Compare July 29, 2026 10:28

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on itamar-starkware).

@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from fa82ee8 to f9c09e0 Compare July 29, 2026 13:11
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from cee73da to 3999c5f Compare July 29, 2026 13:11
@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from f9c09e0 to a953779 Compare July 30, 2026 10:38
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from 3999c5f to 28b2098 Compare July 30, 2026 10:38
@itamar-starkware
itamar-starkware force-pushed the committer-witness-blob-size-log branch from a953779 to 6a4d13c Compare July 30, 2026 11:07
@itamar-starkware
itamar-starkware force-pushed the committer-latency-alerts branch from 28b2098 to 06b11a2 Compare July 30, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants