Skip to content

fix(view): Call View::forceRedraw() instead of doing tricks to refresh the camera normally #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 2 commits into from
Feb 26, 2026
+5 −21
Merged

fix(view): Call View::forceRedraw() instead of doing tricks to refresh the camera normally #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a249f1
fix(view): Call View::forceRedraw() to refresh the camera instead of …
xezon Feb 25, 2026
4c018b8
Replicate in Generals
xezon Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/BaseHeightMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,7 @@ void BaseHeightMapRenderObjClass::adjustTerrainLOD(Int adj)
newROBJ->m_roadBuffer->loadRoads();
}
if (TheTacticalView) {
TheTacticalView->setAngle(TheTacticalView->getAngle() + 1);
TheTacticalView->setAngle(TheTacticalView->getAngle() - 1);
TheTacticalView->forceRedraw();
}
}

Expand Down Expand Up @@ -485,11 +484,8 @@ void BaseHeightMapRenderObjClass::ReAcquireResources()
}
#endif

if (TheTacticalView)
{ TheTacticalView->forceRedraw(); //force map to update itself for the current camera position.
//for some reason we need to do it twice otherwise we sometimes end up with a black map until
//the player moves.
TheTacticalView->forceRedraw();
if (TheTacticalView) {
TheTacticalView->forceRedraw(); //force map to update itself for the current camera position.
}
}

Expand Down
8 changes: 1 addition & 7 deletions Generals/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,13 +806,7 @@ void ScriptActions::doPitchCamera(Real pitch, Real sec)
void ScriptActions::doOversizeTheTerrain(Int amount)
{
oversizeTheTerrain(amount);
Coord2D offset;
offset.x = 0.0001f;
offset.y = 0.0001f;
TheTacticalView->scrollBy(&offset);
offset.x = -0.0001f;
offset.y = -0.0001f;
TheTacticalView->scrollBy(&offset);
TheTacticalView->forceRedraw();
}

//-------------------------------------------------------------------------------------------------
Expand Down
8 changes: 1 addition & 7 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,13 +833,7 @@ void ScriptActions::doPitchCamera(Real pitch, Real sec, Real easeIn, Real easeOu
void ScriptActions::doOversizeTheTerrain(Int amount)
{
oversizeTheTerrain(amount);
Coord2D offset;
offset.x = 0.0001f;
offset.y = 0.0001f;
TheTacticalView->scrollBy(&offset);
offset.x = -0.0001f;
offset.y = -0.0001f;
TheTacticalView->scrollBy(&offset);
TheTacticalView->forceRedraw();
}

//-------------------------------------------------------------------------------------------------
Expand Down
Loading