fix(view): Call View::forceRedraw() instead of doing tricks to refresh the camera normally#2352
Merged
xezon merged 2 commits intoTheSuperHackers:mainfrom Feb 26, 2026
Merged
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngineDevice/Source/W3DDevice/GameClient/BaseHeightMap.cpp | Replaced camera refresh tricks with forceRedraw() calls; removed second forceRedraw() call in ReAcquireResources() that was previously needed to prevent black map issues |
| Generals/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp | Replaced scroll trick with clean forceRedraw() call in doOversizeTheTerrain() |
| GeneralsMD/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp | Replaced scroll trick with clean forceRedraw() call in doOversizeTheTerrain() |
Last reviewed commit: 4c018b8
Skyaero42
reviewed
Feb 25, 2026
Author
|
Replicated to Generals without conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change calls
View::forceRedraw()to refresh the camera instead of doing tricks.TODO