Fix off-by-one in pgResponsive when any <th> is hidden#2106
Merged
luanfreitasdev merged 1 commit intoMay 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡ PowerGrid - Pull Request
Description
PR #1940 introduced a regression that crashes
pgResponsivewithnull.textContent.getItemsToHide()pushesvisibleThs.indexOf(item) + 1, but the value is later used as a CSS:nth-child(n)selector — and:nth-childcounts all siblings, includingdisplay: noneones. As soon as any<th>is hidden (which is always true on initial render due to thex-show="hasHiddenElements"toggle column intr.blade.php), the indexes drift and:nth-childresolves to the wrong column.Fix: index against the unfiltered
itemslist, plus a defensive?.textContent ?? ''guardThe filtering from #1940 stays in place for the sort/iterate step, so hidden columns still don’t leak into the expand area — only the index used for :nth-child is corrected.
Related Issue(s):
Documentation
This PR requires Documentation update?