Skip to content

Fix off-by-one in pgResponsive when any <th> is hidden #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luanfreitasdev merged 1 commit into from
May 11, 2026
+2 −2
Merged

Fix off-by-one in pgResponsive when any <th> is hidden #2106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/js/components/pgResponsive/onResize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function getItemsToHide(element, tableWidth) {
if (fitsMoreItems && calc <= tableWidth && (calc + itemWidth <= tableWidth)) {
calc += itemWidth;
} else {
itemsToHide.push(visibleThs.indexOf(item) + 1)
itemsToHide.push(items.indexOf(item) + 1)
fitsMoreItems = false
}
})
Expand Down Expand Up @@ -79,7 +79,7 @@ function fillTableExpand(element, hideItems) {

if (!expandContainer) continue

let rowName = element.querySelector(`table thead tr th:nth-child(${hideItem}) span[data-value]`).textContent
let rowName = element.querySelector(`table thead tr th:nth-child(${hideItem}) span[data-value]`).textContent ?? ''

const rowValue = row.querySelector(`tr:last-child td:nth-child(${hideItem})`)?.innerHTML

Expand Down
Loading