Skip to content

Update onResize.js#1940

Merged
luanfreitasdev merged 1 commit into
Power-Components:6.xfrom
denosaurusz:6.x
Jun 27, 2025
Merged

Update onResize.js#1940
luanfreitasdev merged 1 commit into
Power-Components:6.xfrom
denosaurusz:6.x

Conversation

@denosaurusz

Copy link
Copy Markdown
Contributor

Remove hidden columns from responsive expanded.

⚡ PowerGrid - Pull Request

  • Bug fix
  • Enhancement
  • New feature
  • Breaking change

Description

...

Related Issue(s):

Documentation

This PR requires Documentation update?

  • Yes
  • No
  • I have already submitted a Documentation pull request.

Remove hidden columns from responsive expanded.
@luanfreitasdev

Copy link
Copy Markdown
Member

Thank you @denosaurusz!

@luanfreitasdev luanfreitasdev merged commit 1621683 into Power-Components:6.x Jun 27, 2025
23 checks passed
lsmedia added a commit to lsmedia/livewire-powergrid that referenced this pull request May 8, 2026
@lsmedia

lsmedia commented May 8, 2026

Copy link
Copy Markdown
Contributor

Hi @denosaurusz, @luanfreitasdev — thanks for this; the intent is right but it introduced an off-by-one. The pushed visibleThs.indexOf(...)+1 is later consumed as CSS :nth-child(n), which counts all siblings including display:none ones, so the index drifts as soon as any <th> is hidden — and tr.blade.php’s x-show="hasHiddenElements" toggle column makes that always true on first paint, causing null.textContent to throw.

Opened #2106 with a minimal fix that keeps your filtering (hidden columns still excluded from the expand area) and only corrects the pushed index back to the unfiltered list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants