Repository navigation
fix(ci): package-apk portal build uses setup-node 20, not Debian Node 12 - #366
Merged
Merged
Conversation
The apk packaging job runs inside the openwrt/sdk container (Debian bullseye) where 'apt-get install nodejs npm' provides Node 12.22.12. The captive-portal build (vite/vitest toolchain, needs Node >= 18) crashes on optional-chaining syntax: module.enableCompileCache?.(). package-ipk already uses actions/setup-node@v4 with node-version 20 (since 70ec4e6); this applies the identical pattern to package-apk. Main-push builds have been red at this step since Aug 26.
c03rad0r
self-requested a review
August 27, 2026 15:11
c03rad0r
approved these changes
Aug 27, 2026
This was referenced Aug 30, 2026
c03rad0r
added a commit
that referenced
this pull request
Sep 8, 2026
* docs(changelog): backfill [Unreleased] for v0.6.0 Add entries for PRs #331, #312, #299, #347, #361, #365, #366, #368, #369, #370 under [Unreleased] (Added / Changed / Internal), matching existing Keep-a-Changelog style. Ref #339. * docs(changelog): backfill #359 and #353 entries --------- Co-authored-by: Felix <301398501+felixfelix-bot@users.noreply.github.com> Co-authored-by: c03rad0r <1100745+c03rad0r@users.noreply.github.com>
felixfelix-bot
added a commit
to felixfelix-bot/tollgate-module-basic-go
that referenced
this pull request
Sep 20, 2026
… 12 (OpenTollGate#366) The apk packaging job runs inside the openwrt/sdk container (Debian bullseye) where 'apt-get install nodejs npm' provides Node 12.22.12. The captive-portal build (vite/vitest toolchain, needs Node >= 18) crashes on optional-chaining syntax: module.enableCompileCache?.(). package-ipk already uses actions/setup-node@v4 with node-version 20 (since 32a70e7); this applies the identical pattern to package-apk. Main-push builds have been red at this step since Aug 26. Co-authored-by: Felix <301398501+felixfelix-bot@users.noreply.github.com>
felixfelix-bot
added a commit
to felixfelix-bot/tollgate-module-basic-go
that referenced
this pull request
Sep 20, 2026
* docs(changelog): backfill [Unreleased] for v0.6.0 Add entries for PRs OpenTollGate#331, OpenTollGate#312, OpenTollGate#299, OpenTollGate#347, OpenTollGate#361, OpenTollGate#365, OpenTollGate#366, OpenTollGate#368, OpenTollGate#369, OpenTollGate#370 under [Unreleased] (Added / Changed / Internal), matching existing Keep-a-Changelog style. Ref OpenTollGate#339. * docs(changelog): backfill OpenTollGate#359 and OpenTollGate#353 entries --------- Co-authored-by: Felix <301398501+felixfelix-bot@users.noreply.github.com> Co-authored-by: c03rad0r <1100745+c03rad0r@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every main push since Aug 26 fails at
package-apk: the captive-portal build (npm ci && vite build) crashes withRoot cause
Commit 70ec4e6 (Aug 19) added the portal build to both packaging jobs with different Node installs:
package-ipk:actions/setup-node@v4node 20 — workspackage-apk:apt-get install -y nodejs npminside theopenwrt/sdk:...container (Debian bullseye) — Node 12.22.12, portal toolchain needs >= 18PR runs skip the apk job (
compile-binariesis main-only), so PR checks stayed green while main was red.Fix
Replace the apt install with the identical setup-node@v4 pattern package-ipk already uses.
actions/checkout@v6already proves the node20 action runtime works in this exact container. Nocache: npm(lockfile is fetched at runtime from the portal repo).portal-build.shappears exactly twice in the workflow; no other job needs Node.