Skip to content

Build portal once per workflow run, not per matrix leg #367

Description

@felixfelix-bot

package-ipk and package-apk each run packaging/portal-build.sh on every matrix leg (up to ~12 ipk + 3 apk on main), redundantly cloning the portal repo and running npm ci && vite build per leg (~1-3 min each).

Worse, PORTAL_REF=main is resolved independently per leg, so concurrent legs can embed different portal commits in packages published under one BUILD_ID.

Fix: dedicated build-portal job (ubuntu-latest, setup-node@v4, pins/echoes resolved PORTAL_REF) -> actions/upload-artifact -> package jobs download-artifact into packaging/files/tollgate-captive-portal-site/. Also makes PR runs actually validate the portal build path.

Not urgent; separate from the Node 12 hotfix (#366).

Activity

  1. Amperstrand commented on Aug 28, 2026

    @Amperstrand
    Collaborator

    Implemented by #368 (merged 2026-08-27 15:51 UTC) — the standalone build-portal job + portal-assets artifact with 7-day retention. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions