Skip to content

docs(changelog): backfill [Unreleased] for v0.6.0 - #373

Merged
c03rad0r merged 3 commits into
OpenTollGate:mainfrom
felixfelix-bot:changelog/v0.6.0-backfill
Sep 8, 2026
Merged

c03rad0r merged 3 commits into
OpenTollGate:mainfrom
felixfelix-bot:changelog/v0.6.0-backfill

Conversation

@felixfelix-bot

Copy link
Copy Markdown
Contributor

Backfills the [Unreleased] section of CHANGELOG.md with entries for PRs merged since the v0.6.0 cut that were missing changelog entries: #331, #312, #299, #347, #361, #365, #366, #368, #369, #370.

Each entry matches the existing Keep-a-Changelog style (bold lead-in, wrapped, PR link). Categories: Added / Changed / Internal (CI, tests, refactors, docs).

Ref #339.

@Amperstrand Amperstrand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage check from Amperstrand's side (cross-ref #339): diffed this backfill against all PRs merged since v0.5.0. Two entries appear to be missing — one of them release-critical.

1. #359 — fix: stop injecting test mint in release builds (merged 2026-08-26) — MISSING.
Before this, isDevBuild() saw GitBranch == "unknown" (the local build script never set it via ldflags) and injected a test mint with dummy invoices into every release ipk. For anyone running affected builds this is the most important entry in the v0.6.0 changelog. [Unreleased] currently has no entry for it (the only testnut mention in the section is unrelated test-matrix text). Belongs under Fixed.

2. #353 — feat(wgm): vendor IE discovery + calibrated score boost (merged 2026-08-30) — MISSING.
The existing wgm entry still reads "placeholders until vendor-IE discovery lands", i.e. it describes the pre-#353 state. Needs an Added entry, and that placeholder sentence updated.

Minor / optional:

  • #355 and #343 (gofmt cleanup + gofmt pre-commit hook) have no entries — fine to omit as cosmetic, but since this PR adds an Internal category, listing them keeps the "everything since v0.5.0 is accounted for" property.
  • The portal-decoupling entries (#348 et al.) are present but carry no PR links, unlike neighboring entries — style nit only.

Everything else from the merged-since-v0.5.0 set cross-checks clean against [Unreleased] + this PR. Happy to re-verify after a push.

@felixfelix-bot

Copy link
Copy Markdown
Contributor Author

CHANGES_REQUESTED addressed — pushed ff19edb.

Added the two missing entries:

  1. fix: stop injecting test mint in release builds #359 (test-mint fix) — Added under Fixed: describes how the local build script leaked test mint into release builds via isDevBuild() misidentifying "unknown" branch as dev mode, and the fix (ldflags + fallthrough guard).
  2. feat(wgm): vendor IE discovery + calibrated score boost (rebased onto main) #353 (vendor-IE discovery) — Added under Added: describes vendor IE encode/decode from wire-format spec, calibrated score boost, encoder overflow check, config schema field.
  3. Updated the feat(wgm): discovery logger — structured scan history + CLI summary #312 placeholder — The old text "placeholders until vendor-IE discovery lands (fix(config): vendor_ie_discovery not Required — 1-line schema fix #332)" now reads "now populated since vendor-IE discovery landed (feat(wgm): vendor IE discovery + calibrated score boost (rebased onto main) #353)."

Can re-request review whenever someone has bandwidth.

@Amperstrand Amperstrand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both gaps from my earlier review are addressed — #359 entry (accurate mechanism: unknown-branch dev-mode → test-mint injection, script + IsDevBuild safelist) and #353 entry (plus the stale placeholder wording in the #312 entry corrected). Cross-checked against my earlier verification of both PRs on main. LGTM.

@c03rad0r
c03rad0r merged commit 4146503 into OpenTollGate:main Sep 8, 2026
felixfelix-bot added a commit to felixfelix-bot/tollgate-module-basic-go that referenced this pull request Sep 13, 2026
…n via OpenTollGate#385

CHANGELOG.md's `[v0.6.0-alpha2]` entry (moved out of `[Unreleased]` by
OpenTollGate#373) and RELEASE-NOTES.md's "the SDK build tree is cached and every heavy
job has a timeout" bullet (rewritten by OpenTollGate#380) both describe OpenTollGate#370 as
shipped. It is not on `main`: OpenTollGate#370 merged into the stacked
`ci/trigger-hygiene` branch *after* OpenTollGate#369 had already been squash-merged as
`db8af35`, so none of OpenTollGate#370's 16 lines were in the tree either document
describes.

Both entries now name OpenTollGate#385, the PR that carries OpenTollGate#370's content onto
`main`, and the changelog entry no longer lists a `publish-metadata`
timeout among OpenTollGate#370's additions (that job has carried
`timeout-minutes: 15` since `218cd2d`). The release headings, section
order and every other line are untouched.

Refs OpenTollGate#370, OpenTollGate#339.
c03rad0r added a commit that referenced this pull request Sep 13, 2026
…370 follow-up) (#385)

* ci(apk): cache SDK build trees per target + job timeouts (#370 follow-up)

PR #370 is marked MERGED on GitHub but none of its content is on `main`:

  git merge-base --is-ancestor 3f53827 origin/main   # false
  git diff 3f53827^1 3f53827 -- .github/workflows/build-package.yml
  # 16 insertions(+), 0 deletions(-)

Cause: #370's base was the stacked `ci/trigger-hygiene` branch (#369). #369
landed on `main` as the squash db8af35 54 seconds before #370 merged into
that already-merged branch, so #370's commits were orphaned and `main` never
saw them. `main` still has no SDK cache and no timeout on any heavy job
except `publish-metadata` (pre-existing since 218cd2d), which means
`package-apk` falls back to the 360-minute default.

This applies #370's own delta. One of its 16 lines is NOT applied: #370 also
re-declares a job-level `timeout-minutes: 15` on `publish-metadata`, which
`main` already carries at the same job (introduced by 218cd2d, #97). Taking
it verbatim duplicates the mapping key - actionlint:

  key "timeout-minutes" is duplicated in "publish-metadata" job.

Net change: 15 insertions, 0 deletions.

  - compile-binaries: timeout-minutes: 30
  - build-portal:     timeout-minutes: 15
  - package-ipk:      timeout-minutes: 30
  - package-apk:      timeout-minutes: 90
  - package-apk: SHA-pinned actions/cache@v5 step restoring /builder/dl,
    /builder/staging_dir and /builder/build_dir, keyed
    apk-sdk-<matrix.sdk>-25.12.0-<hashFiles('packaging/**')> with
    restore-keys fallback.

No other changes.

* docs(changelog): #370's SDK cache/timeouts only reach main via #385

CHANGELOG.md's `[v0.6.0-alpha2]` entry (moved out of `[Unreleased]` by
#373) and RELEASE-NOTES.md's "the SDK build tree is cached and every heavy
job has a timeout" bullet (rewritten by #380) both describe #370 as
shipped. It is not on `main`: #370 merged into the stacked
`ci/trigger-hygiene` branch *after* #369 had already been squash-merged as
`db8af35`, so none of #370's 16 lines were in the tree either document
describes.

Both entries now name #385, the PR that carries #370's content onto
`main`, and the changelog entry no longer lists a `publish-metadata`
timeout among #370's additions (that job has carried
`timeout-minutes: 15` since `218cd2d`). The release headings, section
order and every other line are untouched.

Refs #370, #339.

---------

Co-authored-by: Felix <301398501+felixfelix-bot@users.noreply.github.com>
Co-authored-by: c03rad0r <1100745+c03rad0r@users.noreply.github.com>
felixfelix-bot added a commit to felixfelix-bot/tollgate-module-basic-go that referenced this pull request Sep 20, 2026
* docs(changelog): backfill [Unreleased] for v0.6.0

Add entries for PRs OpenTollGate#331, OpenTollGate#312, OpenTollGate#299, OpenTollGate#347, OpenTollGate#361, OpenTollGate#365, OpenTollGate#366, OpenTollGate#368,
OpenTollGate#369, OpenTollGate#370 under [Unreleased] (Added / Changed / Internal), matching
existing Keep-a-Changelog style. Ref OpenTollGate#339.

* docs(changelog): backfill OpenTollGate#359 and OpenTollGate#353 entries

---------

Co-authored-by: Felix <301398501+felixfelix-bot@users.noreply.github.com>
Co-authored-by: c03rad0r <1100745+c03rad0r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants