Repository navigation
Conversation
teknium1
added a commit
that referenced
this pull request
Nov 20, 2026
…-day aggregation #48 predates #49 (per-session cache), #262 (per-day buckets) and the Chinese subject support, so its commit landed with main's side of those hunks. This applies its rule across them: - extraction: only user turns and the title create or score subjects; previews, tool names and tool calls do not. Title text (and title quotes) rank but do not count as user-raised. The unquoted Han phrase still comes only from the first non-empty user text, and the Han candidate cap stays. - units carry `user_supported` in subject and per-day candidates; the day log ranks user-raised subjects first, as the subject list does. - no fallback snippet: a subject lists only snippets that mention it. The cache sidecar moves to session_units-v2.json so v1 units (no user_supported, with a fallback) are rebuilt, not reused. - snippet matching keeps Han characters, so Chinese subjects get their snippets. - tests that relied on preview subjects, assistant-only sessions or tool work items now state the new rule.
Contributor
Author
Contributor
Author
|
Credit to @tillstriegel, who wrote this fix (originally NousResearch/hermes-memory-wiki#3): his commit is carried with authorship in #436, which landed via #451. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from NousResearch/hermes-memory-wiki#3 by @tillstriegel.
hermes-memory-wikimoved into this monorepo (see the README), so this is the same commit(s) applied undermemory-wiki/, authorship kept. Review continues here.Original description:
Summary
Prioritize what the user actually discussed over execution noise in Memory Wiki topics.
Verification
HERMES_AGENT_REPO=<hermes-agent-checkout> <hermes-python> -m pytest tests/ -o 'addopts=' -q.npm run checkandgit diff --checkpass.Checks / CI state
GET /repos/NousResearch/hermes-memory-wiki/actions/workflowsreturns zero workflows, and the exact head below reports zero check runs and zero commit statuses (statusCheckRollup: []). There is no upstream check for this head that is passing, failing or pending — none exists, and none is claimed here. Required-check/branch-protection state could not be read with the available token (the branch-protection endpoint returns 404 for a non-admin collaborator), so it is reported as unverified rather than absent.Developmentsection ofREADME.mdat head9ae86a3d8005688e0c299b0e28f655e760d68f64: 38 passed,npm run checkclean,git diff --check origin/main...HEADclean, working tree clean.Scope and limitations
Backend relevance, tests and documentation only. No cache/loading/UI changes; independent of the separate performance PR and based directly on upstream
main(single commit on top of9bc3913, no commits fromperf/search-cache-feedback). Diff is exactly four files:README.md,dashboard/memory_wiki_core.py,tests/test_memory_wiki_core.py,tests/test_topic_relevance.py.Extraction remains deterministic English-oriented regex/keyword heuristics, not semantic topic understanding. Existing bounded history and truncation limits remain (sessions leaving the loaded window are out of scope). No LLM/network ranking, new dependencies, settings, or API response-key changes. No live session data is included. Not merged, installed or activated.
Infographic