Skip to content

fix(memory-wiki): prioritize user topics over tool and system noise (salvage #48) - #436

Closed
teknium1 wants to merge 2 commits into
mainfrom
salvage/48-user-topic-relevance
Closed

teknium1 wants to merge 2 commits into
mainfrom
salvage/48-user-topic-relevance

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #48 (port of NousResearch/hermes-memory-wiki#3 by @tillstriegel), rebased onto current main with authorship kept, plus one fix on top.

What #48 does: topics come from user turns and the title, not from tool/system/preview noise. Assistant text can only add context to an existing topic, never create one. User-supported topics rank first in Subjects and Daily logs. Tool-name rows are dropped from work items. This also stops cron prompt text and tool names (terminal, exit code) from flooding the index, which is the noise #379 describes; #424 fixes that by source.

Fix on top (e7c2016): #48 runs the dotted-identifier regex over free user text, so ordinary prose became subjects: "Use a cache, e.g. redis, i.e. fast. Fix it.Then…" produced e.g, i.e and it.Then. Matches now need parts of 2+ characters with no capital after a dot; snake_case always counts. tools.lookup and search_files are still extracted. The new test fails on #48's head and passes here.

Verification: full memory-wiki/tests 44 passed (main 26). The cherry-pick onto main had no conflicts.

Merge order: this textually conflicts with #250 (Han extraction in the same extract_subject_candidates hunks), #262 and #318 (memory_wiki_core.py). Land it after those; I'll rebase it.

Supersedes #48.
Co-authored-by: Till Striegel till.striegel@gmail.com

tillstriegel and others added 2 commits November 19, 2026 04:17
The dotted-identifier scan over user text turned "e.g", "i.e" and "it.Then"
into subjects. Require 2+ char parts with no capital after a dot (snake_case
always counts).
@teknium1

Copy link
Copy Markdown
Contributor Author

Landed on main via #451 (tip 5e11c86). To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants