Skip to content
This repository was archived by the owner on Oct 11, 2026. It is now read-only.

fix: prioritize user topics over tool and system noise - #3

Closed
tillstriegel wants to merge 1 commit into
NousResearch:mainfrom
tillstriegel:fix/user-topic-relevance
Closed

tillstriegel wants to merge 1 commit into
NousResearch:mainfrom
tillstriegel:fix/user-topic-relevance

Conversation

@tillstriegel

@tillstriegel tillstriegel commented Sep 17, 2026 •

Copy link
Copy Markdown

Summary

Prioritize what the user actually discussed over execution noise in Memory Wiki topics.

  • Derive subjects from every user turn, with session titles as secondary evidence and an intentional title-only fallback. Exclude unverified previews, tool/system/developer text and tool-call metadata from topic creation/scoring.
  • Preserve explicitly discussed identifiers (including snake_case/dotted tool names), packages, commands, paths and plain-language phrases. Read text blocks from structured message content without interpreting image payloads or metadata as prose.
  • Rank user-supported topics first across subjects and daily logs; machine repetition cannot create topics or boost scores/order. Message counts remain factual activity metadata.
  • Prefer user snippets. Assistant text can provide matching context for existing topics, not introduce new ones. Filter noisy daily work items and deduplicate repeated assistant support.

Verification

  • Baseline: 21 tests passed.
  • Final: 38 tests passed with HERMES_AGENT_REPO=<hermes-agent-checkout> <hermes-python> -m pytest tests/ -o 'addopts=' -q.
  • Synthetic SQLite SessionDB + FastAPI coverage for overview, subjects/query/detail, days/day detail and read-only database guarantees; noisy-role/repetition, later user turns, explicit tool names, empty/title-only sessions, ranking limits, multimodal text and empty/punctuation-only assistant regressions.
  • npm run check and git diff --check pass.
  • Independent defect-first exact-diff review; findings repaired and regression-tested before publication.

Checks / CI state

  • This repository has no CI configured: GET /repos/NousResearch/hermes-memory-wiki/actions/workflows returns zero workflows, and the exact head below reports zero check runs and zero commit statuses (statusCheckRollup: []). There is no upstream check for this head that is passing, failing or pending — none exists, and none is claimed here. Required-check/branch-protection state could not be read with the available token (the branch-protection endpoint returns 404 for a non-admin collaborator), so it is reported as unverified rather than absent.
  • All verification for this exact head is local, reproduced by the commands in the Development section of README.md at head 9ae86a3d8005688e0c299b0e28f655e760d68f64: 38 passed, npm run check clean, git diff --check origin/main...HEAD clean, working tree clean.

Scope and limitations

Backend relevance, tests and documentation only. No cache/loading/UI changes; independent of the separate performance PR and based directly on upstream main (single commit on top of 9bc3913, no commits from perf/search-cache-feedback). Diff is exactly four files: README.md, dashboard/memory_wiki_core.py, tests/test_memory_wiki_core.py, tests/test_topic_relevance.py.

Extraction remains deterministic English-oriented regex/keyword heuristics, not semantic topic understanding. Existing bounded history and truncation limits remain (sessions leaving the loaded window are out of scope). No LLM/network ranking, new dependencies, settings, or API response-key changes. No live session data is included. Not merged, installed or activated.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for this! hermes-memory-wiki has moved into NousResearch/hermes-official-plugins, the single repo for Nous's official Hermes plugins, and this repo is being archived. Your commit is ported as-is, with your authorship, to NousResearch/hermes-official-plugins#48, where review continues and CI runs it on Linux, macOS and Windows. Further changes go there. Closing this one as moved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants