Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

mrc-6634 use new packit interface #34

Merged
EmmaLRussell merged 3 commits into from
Jul 31, 2025
Merged

mrc-6634 use new packit interface #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211ba7c
use new packit interface
EmmaLRussell Jul 30, 2025
f14cced
packit should have sensible exit code now
EmmaLRussell Jul 30, 2025
f529a7e
remove exit code ignore in cleanup too
EmmaLRussell Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.idea
.cache
.packit_identity
celerybeat-schedule
/*/__pycache__/
/*/*/__pycache__/
Expand Down
7 changes: 2 additions & 5 deletions scripts/run-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,8 @@ $here/montagu_cli.sh addRole test.user user
# Run packit
hatch env run pip3 install constellation
hatch env run pip3 install packit-deploy
# For some reason packit is emitting exit code 1 despite apparently succeeding. Allow this for now...
set +e
hatch env run -- packit start --pull $here
echo Packit deployed with exit code $?
set -e
hatch env run packit configure $here
hatch env run -- packit start --pull

docker exec montagu-packit-db wait-for-db

Expand Down
5 changes: 1 addition & 4 deletions scripts/run-dev-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ set -ex
function cleanup() {
docker container stop reverse-proxy
docker container rm reverse-proxy -v
# Same exit code issue for packit stop as packit start....
set +e
hatch env run -- packit stop ./scripts
set -e
hatch env run -- packit stop
Copy link
Copy Markdown
Member

@richfitz richfitz Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added support in mrc-ide/packit-deploy#28 to be able to run hatch env run -- packit unconfigure here, which would complete cleanup, but we can sort that out in the parent PR perhaps?

# remove db volume manually rather than --volumes flag to packit, to avoid requiring user confirmation
docker volume rm montagu_packit_db montagu_orderly_library montagu_outpack_volume montagu_orderly_logs
docker compose --project-name montagu down -v
Expand Down