This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Merged
Conversation
richfitz
reviewed
Jul 30, 2025
Member
richfitz
left a comment
richfitz
left a comment
There was a problem hiding this comment.
are the exit code dramas resolved? if not we should investigate...
scripts/run-dependencies.sh
Outdated
| @@ -40,7 +40,8 @@ hatch env run pip3 install constellation | |||
| hatch env run pip3 install packit-deploy | |||
| # For some reason packit is emitting exit code 1 despite apparently succeeding. Allow this for now... | |||
scripts/run-dev-dependencies.sh
Outdated
| @@ -9,7 +9,7 @@ function cleanup() { | |||
| docker container rm reverse-proxy -v | |||
| # Same exit code issue for packit stop as packit start.... | |||
richfitz
approved these changes
Jul 31, 2025
| set +e | ||
| hatch env run -- packit stop ./scripts | ||
| set -e | ||
| hatch env run -- packit stop |
Member
There was a problem hiding this comment.
I've added support in mrc-ide/packit-deploy#28 to be able to run hatch env run -- packit unconfigure here, which would complete cleanup, but we can sort that out in the parent PR perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates deps script to use new packit deploy commands, where packit is pre-configured before starting.