fix: update ose-cli image version#4
Merged
minmzzhang merged 2 commits intovalidatedpatterns:mainfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: Min Zhang <[email protected]>
day0hero
reviewed
Mar 24, 2026
| containers: | ||
| - name: setup-s3-credentials | ||
| image: {{ .Values.job.image | default "registry.redhat.io/openshift4/ose-cli:4.15" }} | ||
| image: {{ .Values.job.image | default "registry.redhat.io/openshift4/ose-cli-rhel9:v4.20" }} |
There was a problem hiding this comment.
Why not use the imagestream that ships the cli? Its already in-cluster and aligns with the clusterversion - that way you don't have to worry about updating it?
image-registry.openshift-image-registry.svc:5000/openshift/cli
day0hero
approved these changes
Mar 24, 2026
day0hero
left a comment
day0hero
left a comment
There was a problem hiding this comment.
just the one comment/question about using the imagestream instead of the public image.
otherwise:
/lgtm
minmzzhang
force-pushed
the
update-quay-chart
branch
from
fb3ec16 to
8d849e6
Compare
Replace hardcoded registry.redhat.io/openshift4/ose-cli-rhel9:v4.20 with the cluster-internal cli ImageStream at image-registry.openshift-image-registry.svc:5000/openshift/cli. This image auto-updates with the cluster, eliminating the need to manually track ose-cli version bumps on a monthly/quarterly/yearly basis. Signed-off-by: Min Zhang <[email protected]>
minmzzhang
force-pushed
the
update-quay-chart
branch
from
8d849e6 to
ba621c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.