Skip to content

conformance: add the remaining groups, floats and digests - #1290

Draft
justinhwang wants to merge 1 commit into
conformance-5-edges-vertexesfrom
conformance-6-rest
Draft

justinhwang wants to merge 1 commit into
conformance-5-edges-vertexesfrom
conformance-6-rest

Conversation

@justinhwang

@justinhwang justinhwang commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the last files of the suite: the remaining float measures and the digests.

Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is dev-docs/conformance.md.

Functions covered

  • greatCircleDistanceRads/Km/M between cell centers; getHexagonAreaAvgKm2/M2 and getHexagonEdgeLengthAvgKm/M per resolution, under tolerance.
  • Digests: SHA-256 over thirteen per-cell streams (cells, parents, children, inspection, disks, rings, distances, edges, vertexes, local IJ, compact, round trip, polygon fills) for every cell at resolutions 0 through 7, 115,664,014 cells, per base cell and per resolution; getNumCells and getPentagons checked against every resolution row, digested or not; and a digest over the four validity functions applied to 10 million mutated bit patterns.

Files

File Rows
floats/distances.jsonl 1,083
floats/resolutions.jsonl 17
digests/baseCells.jsonl 976
digests/resolutions.jsonl 8
digests/patterns.jsonl 3

Runners and cost

  • testConformanceDigestsBaseCells and testConformanceDigestsResolutions recompute the streams from the library at test time. They stop at resolution 3 (about a second) unless H3_CONFORMANCE_DIGESTS_MAXRES says otherwise; testConformanceDigestsPatterns stops at one million patterns unless H3_CONFORMANCE_PATTERNS_MAXCOUNT does. The gcc Release Linux job goes to resolution 5 (about a minute per runner); a new weekly test-conformance.yml goes to resolution 6 and ten million patterns.
  • The stream enumeration and serialization move from mkConformance.c to src/apps/applib/lib/conformanceGen.c so that the generator and the runners share one implementation.
  • scripts/conformance_digests.sh produces the resolution 7 rows with one generator process per base cell (an hour single-threaded; minutes on twelve cores), since the generator writes resolutions 0 through 6 in one process.

The discrete files (digests) are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929; the float files agree under tolerance.

Left out: floats/curated.jsonl. h3-go's suite also has 54 curated cells on the antimeridian, where cellArea loses precision in edges crossing ±180° (#1274 fixes that). Without the fix the values are not just wrong but platform-dependent: a res 15 straddling cell differs by 2.6% between arm64 macOS and Windows, so the file could not be committed before #1274 merged. Now that it has, it follows in a small PR, generated with mkConformance -o tests/inputfiles -g floats/curated.jsonl --manifest.

🤖 Generated with Claude Code


Stack created with GitHub Stacks CLI • Give Feedback 💬

@justinhwang
justinhwang added this pull request to stack #1291 November 5, 2026 18:37
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coveralls

coveralls commented Nov 5, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 99.687% — conformance-6-rest into conformance-5-edges-vertexes. No base build found for conformance-5-edges-vertexes.

@justinhwang
justinhwang removed this pull request from stack #1291 November 5, 2026 22:38
@justinhwang
justinhwang added this pull request to stack #1295 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-6-rest branch 2 times, most recently from 49d060b to c5ec390 Compare November 6, 2026 04:47
@justinhwang
justinhwang force-pushed the conformance-6-rest branch 2 times, most recently from 00a0cfa to d785553 Compare November 9, 2026 15:39
@justinhwang justinhwang changed the title Add the remaining conformance groups: floats and digests conformance: add the remaining groups, floats and digests Nov 12, 2026
# job goes to resolution 6 and ten million patterns.
on:
schedule:
- cron: "17 6 * * 1"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be interesting to, as an option, run coverage with the conformance suite.

@justinhwang
justinhwang force-pushed the conformance-6-rest branch 2 times, most recently from 3e99d95 to b54354e Compare November 19, 2026 18:09
Adds the last files of the suite and their runners:

- floats/distances.jsonl: greatCircleDistanceRads/Km/M between cell
  centers; floats/resolutions.jsonl: getHexagonAreaAvgKm2/M2 and
  getHexagonEdgeLengthAvgKm/M per resolution, under tolerance.
- digests/baseCells.jsonl and digests/resolutions.jsonl: SHA-256 digests
  over thirteen per-cell streams for every cell at resolutions 0 through
  7, per base cell and per resolution; digests/patterns.jsonl: a digest
  over the validity functions applied to 10 million mutated bit
  patterns. The runners recompute the streams from the library and stop
  at resolution 3 and one million patterns unless
  H3_CONFORMANCE_DIGESTS_MAXRES and H3_CONFORMANCE_PATTERNS_MAXCOUNT say
  otherwise; the gcc Release Linux job goes to resolution 5 and a weekly
  workflow to resolution 6 and ten million patterns.

The stream enumeration and serialization move from mkConformance to
applib's conformanceGen.c so the runners and the generator share one
implementation; scripts/conformance_digests.sh produces the resolution 7
rows with one generator process per base cell.

The discrete files are byte-identical to the ones generated in h3-go
from v4.5.0 at seed 20260929. h3-go's floats/curated.jsonl (cells on the
antimeridian) is left out until #1274 lands: without that fix
cellArea of those cells differs between platforms by more than the
tolerance.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants