Repository navigation
conformance: add the remaining groups, floats and digests - #1290
Draft
justinhwang wants to merge 1 commit into
Draft
justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 5, 2026 18:50
4b95ac0 to
a382de3
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 5, 2026 19:32
a382de3 to
8f42776
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 5, 2026 20:16
8f42776 to
d4f0798
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 5, 2026 22:17
d4f0798 to
400e2e2
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
2 times, most recently
from
November 6, 2026 04:47
49d060b to
c5ec390
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 6, 2026 16:54
c5ec390 to
82ad278
Compare
isaacbrodsky
force-pushed
the
conformance-6-rest
branch
from
November 8, 2026 16:33
82ad278 to
07d8525
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
2 times, most recently
from
November 9, 2026 15:39
00a0cfa to
d785553
Compare
| # job goes to resolution 6 and ten million patterns. | ||
| on: | ||
| schedule: | ||
| - cron: "17 6 * * 1" |
Collaborator
There was a problem hiding this comment.
It would also be interesting to, as an option, run coverage with the conformance suite.
justinhwang
force-pushed
the
conformance-6-rest
branch
2 times, most recently
from
November 19, 2026 18:09
3e99d95 to
b54354e
Compare
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 19, 2026 18:11
b54354e to
5e732bd
Compare
Adds the last files of the suite and their runners: - floats/distances.jsonl: greatCircleDistanceRads/Km/M between cell centers; floats/resolutions.jsonl: getHexagonAreaAvgKm2/M2 and getHexagonEdgeLengthAvgKm/M per resolution, under tolerance. - digests/baseCells.jsonl and digests/resolutions.jsonl: SHA-256 digests over thirteen per-cell streams for every cell at resolutions 0 through 7, per base cell and per resolution; digests/patterns.jsonl: a digest over the validity functions applied to 10 million mutated bit patterns. The runners recompute the streams from the library and stop at resolution 3 and one million patterns unless H3_CONFORMANCE_DIGESTS_MAXRES and H3_CONFORMANCE_PATTERNS_MAXCOUNT say otherwise; the gcc Release Linux job goes to resolution 5 and a weekly workflow to resolution 6 and ten million patterns. The stream enumeration and serialization move from mkConformance to applib's conformanceGen.c so the runners and the generator share one implementation; scripts/conformance_digests.sh produces the resolution 7 rows with one generator process per base cell. The discrete files are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929. h3-go's floats/curated.jsonl (cells on the antimeridian) is left out until #1274 lands: without that fix cellArea of those cells differs between platforms by more than the tolerance. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
justinhwang
force-pushed
the
conformance-6-rest
branch
from
November 19, 2026 18:40
5e732bd to
f5dd6a5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the last files of the suite: the remaining float measures and the digests.
Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is
dev-docs/conformance.md.Functions covered
greatCircleDistanceRads/Km/Mbetween cell centers;getHexagonAreaAvgKm2/M2andgetHexagonEdgeLengthAvgKm/Mper resolution, under tolerance.getNumCellsandgetPentagonschecked against every resolution row, digested or not; and a digest over the four validity functions applied to 10 million mutated bit patterns.Files
floats/distances.jsonlfloats/resolutions.jsonldigests/baseCells.jsonldigests/resolutions.jsonldigests/patterns.jsonlRunners and cost
testConformanceDigestsBaseCellsandtestConformanceDigestsResolutionsrecompute the streams from the library at test time. They stop at resolution 3 (about a second) unlessH3_CONFORMANCE_DIGESTS_MAXRESsays otherwise;testConformanceDigestsPatternsstops at one million patterns unlessH3_CONFORMANCE_PATTERNS_MAXCOUNTdoes. The gcc Release Linux job goes to resolution 5 (about a minute per runner); a new weeklytest-conformance.ymlgoes to resolution 6 and ten million patterns.mkConformance.ctosrc/apps/applib/lib/conformanceGen.cso that the generator and the runners share one implementation.scripts/conformance_digests.shproduces the resolution 7 rows with one generator process per base cell (an hour single-threaded; minutes on twelve cores), since the generator writes resolutions 0 through 6 in one process.The discrete files (digests) are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929; the float files agree under tolerance.
Left out:
floats/curated.jsonl. h3-go's suite also has 54 curated cells on the antimeridian, wherecellArealoses precision in edges crossing ±180° (#1274 fixes that). Without the fix the values are not just wrong but platform-dependent: a res 15 straddling cell differs by 2.6% between arm64 macOS and Windows, so the file could not be committed before #1274 merged. Now that it has, it follows in a small PR, generated withmkConformance -o tests/inputfiles -g floats/curated.jsonl --manifest.🤖 Generated with Claude Code
Stack created with GitHub Stacks CLI • Give Feedback 💬