Skip to content

conformance: add the edges and vertexes groups - #1289

Draft
justinhwang wants to merge 1 commit into
conformance-4-regionsfrom
conformance-5-edges-vertexes
Draft

justinhwang wants to merge 1 commit into
conformance-4-regionsfrom
conformance-5-edges-vertexes

Conversation

@justinhwang

@justinhwang justinhwang commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the record files and runners for directed edges and vertexes.

Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is dev-docs/conformance.md.

Functions covered

  • originToDirectedEdges with each edge's origin, destination, reverse (reverseDirectedEdge), vertexes (edgeToVertexes, new in v4.6.0) and validity; cellsToDirectedEdge to a target from the 1-disk, including the E_NOT_NEIGHBORS case; directedEdgeToCells, getDirectedEdgeOrigin/Destination, isValidDirectedEdge.
  • cellToVertexes, cellToVertex for vertex numbers 0 to 5, isValidVertex.
  • Under tolerance: edgeLengthRads/Km/M, directedEdgeToBoundary, vertexToLatLng.

Files

File Rows
edges/cells.jsonl 542
vertexes/cells.jsonl 542
floats/edges.jsonl 920
floats/vertexes.jsonl 924

Runners: testConformanceEdges, testConformanceVertexes, testConformanceFloatsEdges, testConformanceFloatsVertexes.

The committed files are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929.

🤖 Generated with Claude Code


Stack created with GitHub Stacks CLI • Give Feedback 💬

@justinhwang
justinhwang added this pull request to stack #1291 November 5, 2026 18:37
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coveralls

coveralls commented Nov 5, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 99.687% — conformance-5-edges-vertexes into conformance-4-regions. No base build found for conformance-4-regions.

@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 8c6c4c5 to 02b5b76 Compare November 5, 2026 19:32
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 02b5b76 to b92b323 Compare November 5, 2026 22:17
@justinhwang
justinhwang removed this pull request from stack #1291 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from b92b323 to 01ae1fa Compare November 5, 2026 22:38
@justinhwang
justinhwang added this pull request to stack #1295 November 5, 2026 22:38
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 01ae1fa to a453bac Compare November 6, 2026 16:54
@isaacbrodsky
isaacbrodsky force-pushed the conformance-5-edges-vertexes branch from a453bac to a238462 Compare November 8, 2026 16:33
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from a238462 to a281f4d Compare November 9, 2026 14:22
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from a281f4d to 24979b8 Compare November 9, 2026 15:39
@justinhwang justinhwang changed the title Add the edges and vertexes conformance groups conformance: add the edges and vertexes groups Nov 12, 2026
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 24979b8 to 4e8c9c8 Compare November 19, 2026 17:51
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 4e8c9c8 to 3840640 Compare November 19, 2026 18:09
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 3840640 to 5ce73db Compare November 19, 2026 18:11
Adds the record files and runners for directed edges and vertexes:
originToDirectedEdges with each edge's origin, destination and validity,
cellsToDirectedEdge to a target from the 1-disk including the
E_NOT_NEIGHBORS case; cellToVertexes, isValidVertex and cellToVertex for
vertex numbers 0 to 5; and under tolerance, the edge lengths,
directedEdgeToBoundary and vertexToLatLng.

The files are the generator's output and are byte-identical to the ones
generated in h3-go from v4.5.0 at seed 20260929.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@justinhwang
justinhwang force-pushed the conformance-5-edges-vertexes branch from 5ce73db to 86707fa Compare November 19, 2026 18:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants