Repository navigation
conformance: add the edges and vertexes groups - #1289
Draft
justinhwang wants to merge 1 commit into
Draft
justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 5, 2026 18:50
d9ca73a to
8c6c4c5
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 5, 2026 19:32
8c6c4c5 to
02b5b76
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 5, 2026 22:17
02b5b76 to
b92b323
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 5, 2026 22:38
b92b323 to
01ae1fa
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 6, 2026 16:54
01ae1fa to
a453bac
Compare
isaacbrodsky
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 8, 2026 16:33
a453bac to
a238462
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 9, 2026 14:22
a238462 to
a281f4d
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 9, 2026 15:39
a281f4d to
24979b8
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 19, 2026 17:51
24979b8 to
4e8c9c8
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 19, 2026 18:09
4e8c9c8 to
3840640
Compare
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 19, 2026 18:11
3840640 to
5ce73db
Compare
Adds the record files and runners for directed edges and vertexes: originToDirectedEdges with each edge's origin, destination and validity, cellsToDirectedEdge to a target from the 1-disk including the E_NOT_NEIGHBORS case; cellToVertexes, isValidVertex and cellToVertex for vertex numbers 0 to 5; and under tolerance, the edge lengths, directedEdgeToBoundary and vertexToLatLng. The files are the generator's output and are byte-identical to the ones generated in h3-go from v4.5.0 at seed 20260929. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
justinhwang
force-pushed
the
conformance-5-edges-vertexes
branch
from
November 19, 2026 18:40
5ce73db to
86707fa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the record files and runners for directed edges and vertexes.
Part of the conformance suite stack (#1285 → #1286 → #1287 → #1288 → #1289 → #1290); the specification is
dev-docs/conformance.md.Functions covered
originToDirectedEdgeswith each edge's origin, destination, reverse (reverseDirectedEdge), vertexes (edgeToVertexes, new in v4.6.0) and validity;cellsToDirectedEdgeto a target from the 1-disk, including theE_NOT_NEIGHBORScase;directedEdgeToCells,getDirectedEdgeOrigin/Destination,isValidDirectedEdge.cellToVertexes,cellToVertexfor vertex numbers 0 to 5,isValidVertex.edgeLengthRads/Km/M,directedEdgeToBoundary,vertexToLatLng.Files
edges/cells.jsonlvertexes/cells.jsonlfloats/edges.jsonlfloats/vertexes.jsonlRunners:
testConformanceEdges,testConformanceVertexes,testConformanceFloatsEdges,testConformanceFloatsVertexes.The committed files are byte-identical to the ones generated in h3-go from v4.6.0 at seed 20260929.
🤖 Generated with Claude Code
Stack created with GitHub Stacks CLI • Give Feedback 💬