fix: set only one hash per version to "arcat" binary for compatibility with Buildbarn and SRI standard #3472
Merged
toastwaffle merged 6 commits intothought-machine:masterfrom Feb 4, 2026
Conversation
…thout this change, Please does not work with Buildbarn
toastwaffle
requested changes
Jan 26, 2026
Collaborator
|
I'm generally happy with the approach, modulo the comments so far. One thing I do want to clarify though...
Actually, it does allow it. Referring to the spec, example 7 covers this case:
Although as we discussed on the issue a little while back, I agree this is a practical solution to make Please more working with the various servers out there. |
Contributor
Author
|
@peterebden thanks for calling that out. I got fooled by AI. I addressed the comments. |
toastwaffle
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildbarn assumes that only one SHA per binary is provided, or the SHAs are of different algorithms.
To enable Buildbarn as a backend to Please, this change is necessary.
With this change, current Buildbarn works as a backend.