Skip to content

fix: set only one hash per version to "arcat" binary for compatibility with Buildbarn and SRI standard #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toastwaffle merged 6 commits into from
Feb 4, 2026
+22 −7
Merged

fix: set only one hash per version to "arcat" binary for compatibility with Buildbarn and SRI standard #3472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8eaecb
fix: SRI standard does not allow multiple hashes of the same type. Wi…
Dec 16, 2025
48b5f57
applied suggestions from review
Feb 2, 2026
cfaafb5
added a comment, moved the error message to 'default'
Feb 2, 2026
803c8fa
fix: making linter happy
Feb 4, 2026
30945da
fix: making linter happy
Feb 4, 2026
560b073
retry circle ci
Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/parse/internal.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ remote_file(
out = "arcat",
binary = True,
hashes = [
"6af2cf108592535701aa9395f3a5deeb48a5dfbe8174a8ebe3d56bb93de2c255", # darwin_amd64
"5070ef05d14c66a85d438f400c6ff734a23833929775d6824b69207b704034bf", # darwin_arm64
"05ad6ac45be3a4ca1238bb1bd09207a596f8ff5f885415f8df4ff2dc849fa04e", # freebsd_amd64
"aec85425355291e515cd10ac0addec3a5bc9e05c9d07af01aca8c34aaf0f1222", # linux_amd64
"8266cb95cc84b23642bca6567f8b4bd18de399c887cb5845ab6a901d0dba54d2", # linux_arm64
"{{ .ArcatHash }}", # defined in internal_package.go
],
visibility = ["PUBLIC"],
)
Expand All @@ -29,3 +25,4 @@ genrule(
binary = True,
)
{{ end }}

22 changes: 20 additions & 2 deletions src/parse/internal_package.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,33 @@ func GetInternalPackage(config *core.Configuration) (string, error) {
url = fmt.Sprintf("%s/%s_%s/%s/please_tools_%s.tar.xz", config.Please.DownloadLocation, runtime.GOOS, runtime.GOARCH, version.PleaseVersion, version.PleaseVersion)
}

var arcatHash string
switch fmt.Sprintf("%s_%s", runtime.GOOS, runtime.GOARCH) {
case "darwin_amd64":
arcatHash = "6af2cf108592535701aa9395f3a5deeb48a5dfbe8174a8ebe3d56bb93de2c255"
case "darwin_arm64":
arcatHash = "5070ef05d14c66a85d438f400c6ff734a23833929775d6824b69207b704034bf"
case "freebsd_amd64":
arcatHash = "05ad6ac45be3a4ca1238bb1bd09207a596f8ff5f885415f8df4ff2dc849fa04e"
case "linux_amd64":
arcatHash = "aec85425355291e515cd10ac0addec3a5bc9e05c9d07af01aca8c34aaf0f1222"
case "linux_arm64":
arcatHash = "8266cb95cc84b23642bca6567f8b4bd18de399c887cb5845ab6a901d0dba54d2"
default:
return "", fmt.Errorf("arcat tool not supported for platform: %s_%s", runtime.GOOS, runtime.GOARCH)
}

data := struct {
ToolsURL string
Tools []string
ToolsURL string
Tools []string
ArcatHash string
}{
ToolsURL: url,
Tools: []string{
"build_langserver",
"please_sandbox",
},
ArcatHash: arcatHash,
}

var buf bytes.Buffer
Expand Down
Loading