Skip to content

Pass transient operands for persisted removals - #140

Open
ehelms wants to merge 1 commit into
theforeman:masterfrom
ehelms:persist-feature-removal-operands
Open

ehelms wants to merge 1 commit into
theforeman:masterfrom
ehelms:persist-feature-removal-operands

Conversation

@ehelms

@ehelms ehelms commented Sep 23, 2026

Copy link
Copy Markdown
Member

Summary

Allow remove parameters with a distinct dest to expose their requested operands to the playbook while applying changes to the shared destination list. This lets playbooks validate removals without persisting the one-shot operation list; the final destination value is saved through Obsah's existing post-success persistence flow. Ignore stale persisted values for non-persistent variables, and document and test the behavior.

Test plan

  • pytest -q — 112 passed.
  • git diff --check — clean.

@ehelms
ehelms marked this pull request as ready for review September 24, 2026 00:58
@ehelms

ehelms commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

This is in conjunction with this use case of it theforeman/foremanctl#746 to handle removing features.

@ehelms
ehelms force-pushed the persist-feature-removal-operands branch from 2414ae6 to 90a3d1f Compare October 10, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant