Repository navigation
Conversation
ehelms
marked this pull request as ready for review
September 24, 2026 00:58
Member
Author
|
This is in conjunction with this use case of it theforeman/foremanctl#746 to handle removing features. |
2 tasks done
ehelms
force-pushed
the
persist-feature-removal-operands
branch
from
October 10, 2026 18:21
2414ae6 to
90a3d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
removeparameters with a distinctdestto expose their requested operands to the playbook while applying changes to the shared destination list. This lets playbooks validate removals without persisting the one-shot operation list; the final destination value is saved through Obsah's existing post-success persistence flow. Ignore stale persisted values for non-persistent variables, and document and test the behavior.Test plan
pytest -q— 112 passed.git diff --check— clean.