Skip to content

Rivian: remove stalk-down hold requirement for ACC set speed update - #474

Open
Geomglot wants to merge 6 commits into
sunnypilot:masterfrom
Geomglot:rivian-down1-fix
Open

Rivian: remove stalk-down hold requirement for ACC set speed update#474
Geomglot wants to merge 6 commits into
sunnypilot:masterfrom
Geomglot:rivian-down1-fix

Conversation

@Geomglot

Copy link
Copy Markdown

Description

This fixes Rivian ACC set-speed handling so a stalk-down action updates the set speed immediately instead of requiring an approximately 0.5 second hold
first.

The previous behavior added delay that did not match observed stock Rivian behavior and could briefly leave the comma display and the Rivian cluster
showing different set speeds.

This change removes the stalk_down_counter hold requirement in Rivian carstate_ext.py. A follow-up comment cleanup is included in the same branch.

Verification

Verified by:

  • on-road testing in a Rivian confirming stalk-down no longer requires a hold before set speed updates
  • comparison against expected Rivian driver behavior

Geomglot added 4 commits May 12, 2026 19:34
Removed stalk down counter logic and simplified speed setting. No need for the stalk to be held down for 0.5s per Rivian manual and on road testing.
@Geomglot

Copy link
Copy Markdown
Author

Small Rivian bugfix PR.

This change is limited to opendbc/sunnypilot/car/rivian/carstate_ext.py and removes the previous stalk-down hold requirement while keeping the snap-to-
current-speed behavior gated on an active stalk-down request.

Checks are now passing, including safety and the full ./test.sh workflow.

@Geomglot

Copy link
Copy Markdown
Author

Note that this is incorporated into #476 as well because the code is intertwined - but this could stand on its own pending 476 being merged

@sunnyhaibin

Copy link
Copy Markdown
Collaborator

@Geomglot do you have a test route with this tested?

@Geomglot

Copy link
Copy Markdown
Author

I just created this one. https://connect.comma.ai/4440a486580ed7c6/00000003--2f49b04818

Test was right around the end of segment 0 start of segment 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants