Rivian: remove stalk-down hold requirement for ACC set speed update - #474
Open
Geomglot wants to merge 6 commits into
Open
Rivian: remove stalk-down hold requirement for ACC set speed update#474Geomglot wants to merge 6 commits into
Geomglot wants to merge 6 commits into
Conversation
Removed stalk down counter logic and simplified speed setting. No need for the stalk to be held down for 0.5s per Rivian manual and on road testing.
Author
|
Small Rivian bugfix PR. This change is limited to Checks are now passing, including safety and the full |
Author
|
Note that this is incorporated into #476 as well because the code is intertwined - but this could stand on its own pending 476 being merged |
Collaborator
|
@Geomglot do you have a test route with this tested? |
Author
|
I just created this one. https://connect.comma.ai/4440a486580ed7c6/00000003--2f49b04818 Test was right around the end of segment 0 start of segment 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes Rivian ACC set-speed handling so a stalk-down action updates the set speed immediately instead of requiring an approximately 0.5 second hold
first.
The previous behavior added delay that did not match observed stock Rivian behavior and could briefly leave the comma display and the Rivian cluster
showing different set speeds.
This change removes the
stalk_down_counterhold requirement in Riviancarstate_ext.py. A follow-up comment cleanup is included in the same branch.Verification
Verified by: