cli: rename thv restart → thv start (add restart alias)
#3151
+69
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `thv start` the canonical CLI command while preserving `thv restart` as a backward-compatible alias. Rename the CLI documentation from `thv_restart.md` to `thv_start.md` to match the canonical command name. The existing implementation and internal identifiers (restartCmd, restart flags, and file name) are intentionally unchanged to minimize churn and avoid surprising downstream contributors. Behavior is unchanged; only the command name, help text, and docs are updated. Fixes stacklok#3046 Signed-off-by: mohamedfawas <[email protected]>
Update the test to search for 'thv start' in the process list instead of 'thv restart'. Signed-off-by: mohamedfawas <[email protected]>
…tart' alias - Rename thv_restart -> thv_start - Update usage examples to prefer 'thv start' - Add note that 'thv restart' remains supported as an alias Signed-off-by: mohamedfawas <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 341 341
Lines 34053 34053
=======================================
Hits 19459 19459
Misses 12985 12985
Partials 1609 1609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3046
Make
thv startthe canonical command while keepingthv restartas a backwards-compatible alias.What I changed
cmd/thv/app/restart.go— changedUseto "start" and addedAliases: []string{"restart"}. The existing RunE logic is unchanged.test/e2e/restart_zombie_test.goto usethv start.thv start(docs/cli/thv_start.md,docs/cli/thv.md,docs/arch/*).What I did NOT change
docs/proposals/THV-1681-groups-in-registry.md— left untouched as it is a design proposal and out of scope for this CLI rename. Happy to update it if maintainers prefer.Checklist for reviewers
thv restartstill works as an aliasthv startLocal checks I ran
go test ./cmd/thv/...go test ./test/e2e -run TestRestartZombie