Skip to content

Conversation

@congx4
Copy link
Contributor

@congx4 congx4 commented Dec 18, 2025

Description

Describe the proposed changes made in this PR.

  1. Removed deprecated GoogleToken/GoogleTokenLoad API: These types no longer exist in reqsign 0.18.x, so I removed the unused DummyTokenLoader struct and its implementation.
  2. Fixed opendal Scheme comparison: Changed storage_info.scheme() == &opendal::Scheme::Gcs to storage_info.scheme() == "gcs" since the OperatorInfo::scheme() now returns &str.
  3. update the test to align with the latest apis from regsign.

How was this PR tested?

cargo check --all-targets && cargo test

make test-all 

"libc",
"linux-raw-sys 0.11.0",
"windows-sys 0.52.0",
"windows-sys 0.61.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is back to 0.61.2 after the first pr. This should resolve the question here.

#6028 (comment)

let signer = reqsign::google::default_signer("storage");

// Create http::Request and extract parts for signing
let http_req = http::Request::builder()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is updated by Claude, I just ensure it keeps the same behavior as before.

Base automatically changed from congxie/bumpDepVersion_1 to main December 19, 2025 16:38
@congx4 congx4 enabled auto-merge (squash) December 19, 2025 17:49
@congx4 congx4 merged commit c4a10f1 into main Dec 19, 2025
8 checks passed
@congx4 congx4 deleted the congxie/bumpDepVersion_2 branch December 19, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants