bump cargo compatible and some incompatible dependencies #6028
Conversation
|
/dd-rust-license-tool --config quickwit/license-tool.toml --manifest-path quickwit/Cargo.toml write |
| ] | ||
|
|
||
| [[package]] | ||
| name = "objc2-core-foundation" |
There was a problem hiding this comment.
Can you check which deps require this and whether this is really needed?
There was a problem hiding this comment.
objc2-core-foundation v0.3.2
├── objc2-io-kit v0.3.2
│ └── sysinfo v0.37.2
There was a problem hiding this comment.
I think this will go away if remove default features, and only add the disk feature of sysinfo. Can you try this?
There was a problem hiding this comment.
we don't have features for sysinfo = "0.37", is this what you meant?
There was a problem hiding this comment.
This is sysinfo Cargo.toml
https://github.com/GuillaumeGomez/sysinfo/blob/main/Cargo.toml
By default it enables the following features
default = ["component", "disk", "network", "system", "user"]
I think we only use disk.
If you disable default features and explicitly opt in for component, I think (?) these deps will go away
There was a problem hiding this comment.
After just using disk feature from sysinfo, other packages were removed, but not this one.
2b74fd8
fulmicoton-dd
left a comment
fulmicoton-dd
left a comment
There was a problem hiding this comment.
See comments.
You can investigate with cargo tree -i.
| syn = { version = "2.0", features = ["extra-traits", "full", "parsing"] } | ||
| sync_wrapper = "1" | ||
| sysinfo = "0.33" | ||
| sysinfo = { version = "0.37", default-features = false, features = ["disk"] } |
…s#6028) * bump compatible deps * update first incompatible batch * add second incompatible batch * add third incompatible batch * update the updated function * updatr 3rd party license * just add disk feature from sysinfo * update 3rd license
Description
bump cargo compatible and some incompatible dependencies
How was this PR tested?