Skip to content

[ET-VK][fix] Widen WAR barrier to a full memory dependency for reused tensors #20915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Jul 15, 2026
Merged

[ET-VK][fix] Widen WAR barrier to a full memory dependency for reused tensors #20915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions backends/vulkan/runtime/api/containers/Tensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,11 +810,22 @@ void vTensorStorage::transition(
dst_stage = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT;
}

VkAccessFlags dst_access = vkapi::vk_access(cur_stage, cur_access);

// WAR hazard: the read-only source access mask yields an execution-only
// dependency that some drivers may drop, so widen it to a full memory
// barrier to keep the write from racing the prior read.
const bool prev_read = (prev_access & vkapi::MemoryAccessType::READ) != 0;
if (prev_read && !prev_written && cur_written) {
src_stage = VK_PIPELINE_STAGE_ALL_COMMANDS_BIT;
dst_stage = VK_PIPELINE_STAGE_ALL_COMMANDS_BIT;
src_access = VK_ACCESS_MEMORY_READ_BIT | VK_ACCESS_MEMORY_WRITE_BIT;
dst_access = VK_ACCESS_MEMORY_READ_BIT | VK_ACCESS_MEMORY_WRITE_BIT;
}

pipeline_barrier.stage.src |= src_stage;
pipeline_barrier.stage.dst |= dst_stage;

VkAccessFlags dst_access = vkapi::vk_access(cur_stage, cur_access);

if (image_) {
pipeline_barrier.images.emplace_back(
src_access, dst_access, cur_layout, new_layout, image_);
Expand Down
Loading