add the flag of Occitania#3179
Merged
evanpelle merged 5 commits intoopenfrontio:mainfrom Feb 13, 2026
Merged
Conversation
|
Jules seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
WalkthroughAdded a new nation "Occitania" (flag/code Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
4 tasks
Collaborator
|
Are there any maps with Occitania nation? |
Contributor
Author
yes, every map with the Spain or the France |
YEEEEESSSSSSSS PPPPPPPPLLLLLLLLLLLLLLEEEEEEAAAAASSSSS AAAAAAADDDDD |
Contributor
|
@SwayLE3 Please add the flag to the correct nations (Change json of maps in the map-generator folder and let the map-generator run afterwards) But maybe you can also do that in a second PR |
Contributor
Author
@FloPinguin Thanks! I’ll add the flag to the correct nations in a second PR. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@map-generator/assets/maps/gatewaytotheatlantic/info.json`:
- Around line 4-8: Occitania's spawn at "Occitania" with coordinates [1700, 630]
is too close to County of Armagnac ([1733, 622]) and may cause overlapping
labels or spawn collisions; update the "coordinates" array for the "Occitania"
entry in info.json to a more distinct position (e.g., shift X or Y by ~50–100
pixels or choose a nearby clear area) and verify visually on the map that the
new coordinates no longer overlap with "County of Armagnac" or other nearby
entries.
In `@map-generator/assets/maps/world/info.json`:
- Around line 4-8: The Occitania entry in info.json (name "Occitania", flag
"1_Occitania", coordinates [955, 240]) is placed too close to France
(coordinates [958, 220]); update the "coordinates" array for Occitania to move
it further from France (e.g., increase the y value to push it south or adjust
the x value to the left/right) so the two markers do not overlap on the world
map, or remove the Occitania object entirely if you decide they shouldn't
coexist on this map; after changing the coordinates, verify the new position
visually against France's coordinates to ensure sufficient separation.
In `@resources/maps/gatewaytotheatlantic/manifest.json`:
- Around line 19-26: Occitania's spawn coordinates ("Occitania" at [1700, 630]
in manifest.json) are only ~33px from County of Armagnac ([1733, 622]) and may
overlap in-game; open the manifest entry for "Occitania" and adjust its
"coordinates" to move it farther from [1733, 622] (e.g., shift X or Y by 30–60
pixels) then re-check in-game to confirm no overlap or conflict with "County of
Armagnac".
In `@resources/maps/world/manifest.json`:
- Around line 19-26: The Occitania entry (the "name": "Occitania" object) has
"coordinates": [955, 240] which is too close to France (~[958, 220]); update the
Occitania "coordinates" values to move its spawn further away (e.g., lower X or
higher Y) so there is clear separation from France, then verify in-game that
both spawns render and function without overlap; adjust the "coordinates" array
in the Occitania object and re-test until spacing is resolved.
Comment on lines
4
to
8
| { | ||
| "coordinates": [1700, 630], | ||
| "name": "Occitania", | ||
| "flag": "1_Occitania" | ||
| }, |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if the flag SVG file "1_Occitania.svg" exists in the resources/flags directory
echo "=== Searching for Occitania flag file ==="
find . -name "*Occitania*" -type f 2>/dev/null | head -20
echo ""
echo "=== Listing structure around map resources ==="
fd "info.json" --type f | grep -E "maps|gateway" | head -10
echo ""
echo "=== Check the actual info.json file for Armagnac and Occitania ==="
fd "info.json" -x cat {} \; | grep -E "(Armagnac|Occitania)" -B2 -A2 | head -40Repository: openfrontio/OpenFrontIO
Length of output: 1377
🏁 Script executed:
#!/bin/bash
# Get more details on the info.json file
echo "=== Full path to the gateway file ==="
fd "info.json" | grep gateway
echo ""
echo "=== Reading the full info.json to see structure ==="
FILE=$(fd "info.json" | grep gateway)
if [ -f "$FILE" ]; then
wc -l "$FILE"
echo ""
echo "=== Content around Occitania and Armagnac ==="
cat -n "$FILE" | sed -n '1,100p'
fiRepository: openfrontio/OpenFrontIO
Length of output: 3100
🏁 Script executed:
#!/bin/bash
# Search for flag files and naming patterns
echo "=== Find where flags are stored ==="
fd "flags" --type d | head -5
echo ""
echo "=== Check for SVG files with numeric prefix ==="
fd "\\.svg$" | grep -E "^[0-9]|/[0-9]" | head -20
echo ""
echo "=== Check for Occitania flag ==="
fd "\\.svg$" | xargs grep -l "Occitania" 2>/dev/null || echo "Not found in SVG files"Repository: openfrontio/OpenFrontIO
Length of output: 846
Occitania spawns almost on top of County of Armagnac.
Occitania's coordinates [1700, 630] are only ~34 pixels away from County of Armagnac at [1733, 622] (lines 5 and 70). On this map, that may cause overlapping labels or spawn collisions. Please double-check that both nations have enough room to coexist, or pick a more distinct spawn point for Occitania.
🤖 Prompt for AI Agents
In `@map-generator/assets/maps/gatewaytotheatlantic/info.json` around lines 4 - 8,
Occitania's spawn at "Occitania" with coordinates [1700, 630] is too close to
County of Armagnac ([1733, 622]) and may cause overlapping labels or spawn
collisions; update the "coordinates" array for the "Occitania" entry in
info.json to a more distinct position (e.g., shift X or Y by ~50–100 pixels or
choose a nearby clear area) and verify visually on the map that the new
coordinates no longer overlap with "County of Armagnac" or other nearby entries.
Comment on lines
19
to
26
| { | ||
| "coordinates": [2144, 344], | ||
| "coordinates": [ | ||
| 1700, | ||
| 630 | ||
| ], | ||
| "flag": "1_Occitania", | ||
| "name": "Occitania" | ||
| }, |
Contributor
There was a problem hiding this comment.
Occitania spawn is very close to County of Armagnac.
Occitania [1700, 630] and County of Armagnac [1733, 622] are only ~33px apart on this 2216×1968 map. Please verify in-game that these two nations do not overlap or conflict at spawn. If they do, nudge one of the coordinates to add some breathing room.
🤖 Prompt for AI Agents
In `@resources/maps/gatewaytotheatlantic/manifest.json` around lines 19 - 26,
Occitania's spawn coordinates ("Occitania" at [1700, 630] in manifest.json) are
only ~33px from County of Armagnac ([1733, 622]) and may overlap in-game; open
the manifest entry for "Occitania" and adjust its "coordinates" to move it
farther from [1733, 622] (e.g., shift X or Y by 30–60 pixels) then re-check
in-game to confirm no overlap or conflict with "County of Armagnac".
resources/maps/world/manifest.json
Outdated
Comment on lines
19
to
26
| { | ||
| "coordinates": [375, 272], | ||
| "coordinates": [ | ||
| 955, | ||
| 240 | ||
| ], | ||
| "flag": "1_Occitania", | ||
| "name": "Occitania" | ||
| }, |
Contributor
There was a problem hiding this comment.
Occitania spawn point may be too close to France on this map.
On this 2000×1000 world map, Occitania is at [955, 240] while France is at [958, 220] — only ~20 pixels apart. This tight spacing could cause spawn overlap or make the two nations hard to distinguish. Consider adjusting the coordinates to give more separation, or verify in-game that both nations spawn correctly without visual or gameplay conflicts.
🤖 Prompt for AI Agents
In `@resources/maps/world/manifest.json` around lines 19 - 26, The Occitania entry
(the "name": "Occitania" object) has "coordinates": [955, 240] which is too
close to France (~[958, 220]); update the Occitania "coordinates" values to move
its spawn further away (e.g., lower X or higher Y) so there is clear separation
from France, then verify in-game that both spawns render and function without
overlap; adjust the "coordinates" array in the Occitania object and re-test
until spacing is resolved.
github-project-automation
bot
moved this from Triage
to Development
in OpenFront Release Management
Duwibi
approved these changes
Feb 13, 2026
github-project-automation
bot
moved this from Development
to Complete
in OpenFront Release Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #(issue number)
Description:
Add a flag : Occitania flag
added the Occitania flag via the svg (same as the flags already in-game) and added it to countries.json
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
young_la_flame