Fix event display: add per-category cap#3104
Fix event display: add per-category cap#3104internet-addict-xyz wants to merge 4 commits intoopenfrontio:mainfrom
Conversation
WalkthroughEvent capping moved from a single global limit to per-category limits (30 per category). The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3efad40 to
8f6d9c3
Compare
|
Are there any maps with Occitania nation? |
@evanpelle PR #3179 is probably the one where you wanted to ask this question, not this PR about events cap? |
oh whoops, thanks |
Description:
Fixes an issue where event spam in one category could delete
events from other categories due to a global cap.
In a normal scenario, if there is spam in some category,
the user would disable it in the filter. However, even though the
messages are filtered out, other messages would still disappear
quickly.
Here is an extreme example of the issue:
https://youtu.be/skEVf3fBxjk?t=1487
This change replaces the global event limit with a per-category cap,
so each
MessageCategoryis isolated.Please complete the following:
I have added screenshots for all UI updates
I process any text displayed to the user through translateText() and I've added it to the en.json file
I have added relevant tests to the test directory
I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
Please put your Discord username so you can be contacted if a bug or regression is found:
internet_addict_