Repository navigation
fix(runtime): process notifications when turn/start omits an ID - #809
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Edo771977
added a commit
to Edo771977/codex-plugin-cc
that referenced
this pull request
Oct 16, 2026
Import upstream openai#809 and openai#811, and the tests of openai#808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #781.
captureTurn()currently buffers every notification whilestate.turnIdis falsy. Ifturn/startreturns withoutturn.id, the buffer is flushed once, but all later notifications, includingturn/completed, are buffered again forever. The task remains stuck running even though the server completed it.turn.id.completeTurn()still adopts the ID from the completion notification if it was omitted from the response.turn.idwith later notifications, and a pre-responseturn/startedfollowed by post-response completion.Verification
npm test), including 2 new real CLI/fake-server integration tests for the missing-turn-ID cases.This is independent of the existing PRs for terminal error handling and inferred completion, which address different failure triggers.