Repository navigation
Import upstream #809 and #811, and the tests of #808 - #22
Merged
Merged
Conversation
…rt omits the turn id Conflict in tests/fake-codex-fixture.mjs: the fork's crash-mid-turn and turn-never-completes branches sit where upstream rewrote the interruptible-slow-task condition. Upstream's missing-turn-id branch is kept as its own early-break block ahead of them, so the fork's branches are untouched.
… values Tests only. The fork already split inline values at the first "=" (since 3d6c7d9), so lib/args.mjs keeps the fork's version and upstream's change to it is dropped in this merge. tests/args.test.mjs was add/add: upstream's tests are appended after the fork's. One is adapted: upstream pins --debug=false=extra as true, while the fork rejects any boolean value other than true/false, so the test now asserts the error. Reverting the fork's parser to split("=", 2) fails four of the imported tests.
openai#808 is listed as tests only, with the one adapted test explained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three upstream PRs. Each one lands as its own merge commit with upstream authorship kept, so any of them can be reverted on its own.
What changes
openai/codex-plugin-cc#809: a turn whose
turn/startresponse has no turn id now completescaptureTurnheld every notification in its buffer until it had a turn id. If theturn/startresponse carried none, every later notification stayed buffered,turn/completedincluded, and the run never finished. Notifications are now buffered only until the start request settles.tests/fake-codex-fixture.mjs, where the fork'scrash-mid-turnandturn-never-completesbranches sit. Upstream'smissing-turn-idbranch was added as a separate block that returns early, placed before them, so the fork's branches are untouched.tests/missing-turn-id.test.mjsfail if the old condition (!state.turnId) is put back.openai/codex-plugin-cc#811:
-hin thebump-versionhelpscripts/bump-version.mjs --helpnow lists the-halias the script already accepted. Merged without conflicts.openai/codex-plugin-cc#808: tests only
=(since3d6c7d9).lib/args.mjskeeps the fork's version, and upstream's change to it is dropped in the merge.tests/args.test.mjsconflicted add/add because both sides created it. Upstream's 9 tests are appended after the fork's.--debug=false=extrato read astrue. The fork rejects any boolean value other thantrue/false, so the test now expects the error.split("=", 2)back into the parser fails 4 of the imported tests.README (imports table) and CHANGELOG are updated.
Verification
node --test tests/*.test.mjs: 396/396 on two full runs.npx tsc -p tsconfig.app-server.json: clean.npm run buildwas not used because its prebuild step runscodex app-server generate-ts, andcodexis not installed here.npm run check-version: all version metadata matches 1.0.6. The version is left at the upstream number on purpose.Not in this PR
untrustedoron-requestwould have their commands refused.🤖 Generated with Claude Code
https://claude.ai/code/session_01UXfvnjSC72HsM6EEPVt2Tg
Generated by Claude Code