[opentelemetry-instrumentation-google-genai] Update generate_content streaming variants to use AsyncStreamWrapper and SyncStreamWrapper from utils#167
Open
DylanRussell wants to merge 6 commits into
Conversation
…ry-python-genai into streamingupdate
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Google GenAI generate_content_stream (sync + async) instrumentation to return the shared opentelemetry-util-genai stream wrappers, aligning streaming lifecycle finalization with the util’s standardized SyncStreamWrapper/AsyncStreamWrapper behavior.
Changes:
- Introduces
GenerateContentStreamWrapperandAsyncGenerateContentStreamWrappersubclasses to drive per-chunk telemetry and finalize spans on stream completion/error. - Refactors both streaming instrumentations to return the util wrappers instead of hand-rolled generator wrappers.
- Adjusts imports to support the new wrapper types.
opentelemetry-instrumentation-google-genai] Update generate_content streaming variants to use AsyncStreamWrapper and SyncStreamWrapper` and opentelemetry-instrumentation-google-genai] Update generate_content streaming variants to use AsyncStreamWrapper and SyncStreamWrapper from utils
lmolkova
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the
generate_contentstreaming variants to use/return the util streaming wrappers.. This makes the code a bit cleaner and also ensures we let the user invoke the stream when they want to instead of us doing it immediately..Fixes # (issue)
Type of change
How has this been tested?
Unit tests
Checklist
See CONTRIBUTING.md
for the style guide, changelog guidance, and more.