Skip to content

Fix android multi digit placeholders - #238

Open
ewerybody wants to merge 2 commits into
mainfrom
fix-android-multi-digit-placeholders
Open

ewerybody wants to merge 2 commits into
mainfrom
fix-android-multi-digit-placeholders

Conversation

@ewerybody

Copy link
Copy Markdown
Member

Changes regular expressions for extracting numbered placeholders to match

  • [1-9] single number from 1 to 9 (no zero, like before) plus:
  • [0-9]* zero or more numbers from 0 to 9
  • for both Python and JS (it had the same issue)
  • also for the "previous" scheme %<
  • adds according tests.

Fixes #237

for extracting multi digit numbered placeholders
add tests
for extracting multi digit numbered placeholders
add tests

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

android_parse_message breaks numbered placeholders with multiple digits

1 participant