Skip to content

Fix the hugging face tokenizer build issues (#211) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Sep 1, 2026
Merged

Fix the hugging face tokenizer build issues (#211) #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,12 @@ runtime.cxx_library(
":regex",
],
exported_deps = [
"fbsource//third-party/nlohmann-json:nlohmann-json",
"fbsource//third-party/re2:re2",
":bpe_tokenizer_base",
":headers",
"//pytorch/tokenizers/third-party:unicode",
],
exported_external_deps = [
"nlohmann_json",
],
)

runtime.cxx_library(
Expand Down
2 changes: 1 addition & 1 deletion include/pytorch/tokenizers/hf_tokenizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class HFTokenizer : public detail::BPETokenizerBase {
* Default initialize with no loaded data
*/
explicit HFTokenizer() {}
~HFTokenizer() {}
~HFTokenizer() override {}

/**
* Load the model data into the
Expand Down
Loading