Fix the hugging face tokenizer build issues (#211) - #211
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@declancm has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117725862. |
meta-codesync
Bot
changed the title
declancm
pushed a commit
to declancm/tokenizers
that referenced
this pull request
Aug 31, 2026
Summary: - Move `nlohmann-json` from `exported_external_deps` to `exported_deps` to fix compatibility with certain build configurations. The explicit `"fbsource//third-party/nlohmann-json:nlohmann-json"` dep is already used in the headers target so it felt like a safe change. - Add override to `~HFTokenizer()` to fix `-Winconsistent-missing-destructor-override warning`. Differential Revision: D117725862
declancm
force-pushed
the
export-D117725862
branch
from
August 31, 2026 18:33
52fbb26 to
00bfbcb
Compare
Summary: - Move `nlohmann-json` from `exported_external_deps` to `exported_deps` to fix compatibility with certain build configurations. The explicit `"fbsource//third-party/nlohmann-json:nlohmann-json"` dep is already used in the headers target so it felt like a safe change. - Add override to `~HFTokenizer()` to fix `-Winconsistent-missing-destructor-override warning`. Differential Revision: D117725862
declancm
force-pushed
the
export-D117725862
branch
from
August 31, 2026 18:36
00bfbcb to
0814f6c
Compare
rascani
approved these changes
Sep 1, 2026
rascani
left a comment
rascani
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
nlohmann-jsonfromexported_external_depstoexported_depsto fix compatibility with certain build configurations. The explicit"fbsource//third-party/nlohmann-json:nlohmann-json"dep is already used in the headers target so it felt like a safe change.~HFTokenizer()to fix-Winconsistent-missing-destructor-override warning.Differential Revision: D117725862