Add reproducible make targets for catalog and certified charts - #355
Merged
Conversation
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
tamalsaha
force-pushed
the
catalog-make-targets
branch
from
July 13, 2026 07:17
f6f407c to
dcabe50
Compare
- Add install-image-packer / install-chart-packer targets that fetch pinned binaries into bin/$(OS)_$(ARCH) - Add update-chart-dependencies, update-certified-charts, update-catalog and verify-catalog targets; wire verify-catalog into verify - Switch CI workflows to the new make targets for installing image-packer and updating chart dependencies - Regenerate kubestash-certified / kubestash-certified-crds to match the current chart-packer output Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
catalog-make-targets
branch
from
July 13, 2026 07:22
dcabe50 to
d69a72a
Compare
The vendored subchart archives under charts/kubestash-certified/charts are regenerated by `helm dependency update` and are not byte-reproducible across helm versions, so committing them made `verify-catalog` fail in CI (the runner's helm repackaged them differently). Match kubedb/installer: gitignore `/charts/kubestash-certified/charts` and untrack the archives so they are rebuilt on demand instead of being verified. Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the catalog-tooling changes from
kubedb.dev/installerto this repo.Makefile
install-image-packer/install-chart-packer— fetch pinned binaries intobin/$(OS)_$(ARCH).update-chart-dependencies— wrapshack/scripts/update-chart-dependencies.sh.update-certified-charts— regenerateskubestash-certified/kubestash-certified-crdsviachart-packer crd-less/crd-only, with a guard that revertsChart.lockwhen only thegenerated:timestamp changed.update-catalog— runs the catalog image-list regeneration.verify-catalog— new gate wired intoverify:somake cifails if the committed catalog/certified charts are stale.Workflows
ci.yml,publish-oci.yml,release.yml: usemake update-chart-dependenciesand install image-packer viamake install-image-packer.cve-report.yml: install image-packer viamake install-image-packerand addbin/linux_amd64to$GITHUB_PATH.Regenerated charts
Running
make update-catalogbrought the previously-stalekubestash-certified/kubestash-certified-crdscharts current with today'schart-packeroutput (certified subcharts now bundlecrds/, certified-crds gained theconfig.kubernetes.io/local-configannotation). This matches whatkubedb.dev/installer's committed certified charts already contain. The image list has no restic-plugin images, soimagelist.yamland the copy/export/import scripts are unchanged.