Build kubestash-certified dependencies in update-chart-dependencies.sh - #356
Merged
Conversation
Since the certified subchart archives under charts/kubestash-certified/charts are gitignored, they must be rebuilt before the chart is packaged or installed. `update-chart-dependencies.sh` only ran `helm dependency update charts/kubestash`, so the OCI publish flow (`helm package charts/kubestash-certified`) failed with "found in Chart.yaml, but missing in charts/ directory". Add the certified chart so its dependencies are built too, matching kubedb/installer. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #355.
#355 gitignored the vendored subchart archives under
charts/kubestash-certified/charts(matchingkubedb/installer) soverify-catalogstops failing on non-reproduciblehelm-packaged.tgz. Buthack/scripts/update-chart-dependencies.shonly built the umbrella chart's dependencies:So after the merge, the OCI publish job failed because the certified chart's
charts/directory was empty:Fix: also build the certified chart's dependencies, matching
kubedb/installer(whose script buildscharts/kubedb-certified):Verified locally: after running the updated script,
charts/kubestash-certified/charts/is repopulated andhelm package charts/kubestash-certifiedsucceeds.