Skip to content

chore: clean up guide toolbar v1 code#960

Draft
thomaswhyyou wants to merge 3 commits intomainfrom
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2
Draft

chore: clean up guide toolbar v1 code#960
thomaswhyyou wants to merge 3 commits intomainfrom
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

Description

** Describe what, why and how of the changes clearly and concisely. Add any additional useful context or info, as necessary. **

Todos

** List any todo items necessary before merging, if any. Delete if none. **

  • Sample todo item 1
  • Sample todo item 2

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

** Attach any screenshots or recordings to visually illustrate the changes, as necessary. Delete if not relevant. **

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Apr 13, 2026 8:46pm
javascript-nextjs-example Ready Ready Preview, Comment Apr 13, 2026 8:46pm
javascript-slack-connect-example Ready Ready Preview, Comment Apr 13, 2026 8:46pm
javascript-slack-kit-example Ready Ready Preview, Comment Apr 13, 2026 8:46pm

Request Review

@linear
Copy link
Copy Markdown

linear bot commented Apr 13, 2026

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: 9b4db11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype@e329d92). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/modules/guide/providers/KnockGuideProvider.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                                           Coverage Diff                                            @@
##             thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype     #960   +/-   ##
========================================================================================================
  Coverage                                                                         ?   63.69%           
========================================================================================================
  Files                                                                            ?      207           
  Lines                                                                            ?     9872           
  Branches                                                                         ?     1274           
========================================================================================================
  Hits                                                                             ?     6288           
  Misses                                                                           ?     3559           
  Partials                                                                         ?       25           
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 93.59% <100.00%> (ø)
packages/client/src/clients/guide/index.ts 100.00% <100.00%> (ø)
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...e/src/modules/guide/context/KnockGuideProvider.tsx 96.36% <ø> (ø)
...eact/src/modules/guide/components/Toolbar/index.ts 100.00% <ø> (ø)
...ckages/react/src/modules/guide/components/index.ts 100.00% <100.00%> (ø)
packages/react/src/modules/guide/index.ts 100.00% <ø> (ø)
...src/modules/guide/providers/KnockGuideProvider.tsx 18.18% <50.00%> (ø)

@thomaswhyyou thomaswhyyou changed the title clean up guide toolbar v1 code chore: clean up guide toolbar v1 code Apr 13, 2026
Base automatically changed from thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype to main April 14, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant