refactor(guide): rename stage results keys to byKey and byType

[thomaswhyyou]

Description

Renames the key and type fields in RecordedSelectionResults to byKey and byType respectively for clarity. No other functional changes, just something that I realized would be good to re-name after introducing it initially.

type RecordedSelectionResults = {
  byKey?: Record<KnockGuide["key"], SelectionResultByLimit>;
  byType?: Record<KnockGuide["type"], SelectionResultByLimit>;
};

[linear]

KNO-12634 [Toolbar] Rename stage.results keys to byKey and byType

[changeset-bot]

⚠️ No Changeset found

Latest commit: e329d92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
javascript-ms-teams-connect-example	Ready	Preview, Comment	Apr 13, 2026 8:45pm
javascript-nextjs-example	Ready	Preview, Comment	Apr 13, 2026 8:45pm
javascript-slack-connect-example	Ready	Preview, Comment	Apr 13, 2026 8:45pm
javascript-slack-kit-example	Ready	Preview, Comment	Apr 13, 2026 8:45pm

[thomaswhyyou]

• chore: clean up guide toolbar v1 code #960
• refactor(guide): rename stage results keys to byKey and byType #959 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[thomaswhyyou]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e329d92. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.00%. Comparing base (ee35de2) to head (e329d92).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #959   +/-   ##
=======================================
  Coverage   63.99%   64.00%           
=======================================
  Files         209      209           
  Lines       10072    10074    +2     
  Branches     1299     1299           
=======================================
+ Hits         6446     6448    +2     
  Misses       3601     3601           
  Partials       25       25           

Files with missing lines	Coverage Δ
packages/client/src/clients/guide/client.ts	90.74% <100.00%> (ø)
packages/client/src/clients/guide/types.ts	100.00% <ø> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts	98.29% <100.00%> (+0.01%)	⬆️