Skip to content

fix: pass falsy args to keep.* template functions #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DragonBot00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass falsy args to keep.* template functions #6772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions keep/iohandler/iohandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,15 +331,10 @@ def _parse(self, tree):
pass
else:
_arg = arg.id
# if the value is empty '', we still need to pass it to the function
# also, if the value is 0 or 0.0, we need to pass it to the function
# 0 == False, so we need to check if the value is not False explicitly
if (
_arg
or _arg == ""
or (_arg == 0 or _arg == 0.0)
and _arg is not False
):
# _arg is None only when no parsing branch matched (no real value produced)
# All other values — including "", 0, False, [], {}, () — are valid
# and must be passed to the function
if _arg is not None:
_args.append(_arg)

# Parse keyword args
Expand Down
Loading