fix: pass falsy args to keep.* template functions - #6772
Open
DragonBot00 wants to merge 1 commit into
Open
DragonBot00 wants to merge 1 commit into
DragonBot00 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IOHandler._parse_tokensilently drops falsy-but-valid arguments tokeep.*template functions. When a function call resolves to[],{},(),False, or0, the argument is silently dropped instead of being passed to the function.The current condition handles
"",0, and0.0but still drops[],{},(), andFalsedue to short-circuit evaluation.Fix
Replace the complex condition with
if _arg is not None:._argis initialized toNoneand staysNoneonly when no parsing branch matched (no real value produced). All other values including"",0,False,[],{},()are valid parsed results that should be passed through.Testing
The edge cases that were previously dropped:
Fixes #6728