Fix build - #37
Open
aochagavia wants to merge 1 commit into
Open
Conversation
Author
|
Blocked by iron/iron#180 |
Contributor
|
@aochagavia Awesome work! Are you on windows? If so, that might be why rust-http-content-type fails to build for you. |
Contributor
|
Just merged iron/iron#181 so restarting travis on this. |
Contributor
|
Still some bugs. There appears to be a problem with iron-test as well, so will try to fix that soon. |
Contributor
|
@aochagavia Any updates on this? I've fixed all the dependencies. |
Author
|
I have accidentally deleted the repository where this branch was. I have forked it again and uploaded the branch with the changes, but GitHub doesn't know it is the same one, so I will need to open a new PR. However, the build is failing because of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc iron/iron#143
Note: I wasn't able to build this locally... Cargo yelled the following at me:
I guess this has something to do with the fact that I am on Windows.