Skip to content

Fixed build, updated to latest Iron. - #40

Closed
gaudecker wants to merge 1 commit into
iron-graveyard:masterfrom
gaudecker:master
Closed

Fixed build, updated to latest Iron.#40
gaudecker wants to merge 1 commit into
iron-graveyard:masterfrom
gaudecker:master

Conversation

@gaudecker

Copy link
Copy Markdown

Deprecation warnings about String::append remain. Closes #37.

@reem

reem commented Oct 15, 2014

Copy link
Copy Markdown
Contributor

Thanks for this work! However, I think cookie should probably be a plugin, so that it doesn't parse cookies if you don't ask for them.

@whodidthis

Copy link
Copy Markdown

If someone were to try and make a plugin version how should the parameters be passed in like the secret here https://github.com/iron/cookie/blob/master/src/parser.rs#L37 ?

Also how do you access the secret when implementing PluginFor eval

@whodidthis

Copy link
Copy Markdown

Right, with your advice found the persistent library.

I tried to create a postgres plugin, and there's probably a lot more into it, but got stuck on trying to read the configuration in the plugin: https://gist.github.com/whodidthis/5036762ae87860bcdab9

@whodidthis

Copy link
Copy Markdown

Tried the same thing in #41 with iron/cookie which I assumed you meant to be used something like

let cookie_settings = CookieSettings { secret: Some("super secret".to_string()) };
chain.link(Read::<CookieParser, CookieSettings>::both(cookie_settings));

I'm stuck on the same problem though

@gaudecker gaudecker closed this Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants